Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Noon] adding new field max_amount to mandate request #3209

Merged
merged 10 commits into from
Jan 17, 2024

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented Dec 27, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves #3844

Note
1.While connector create ensure test_mode is set to true
2.Ensure the currency passed is AED and country is AE

How did you test it?

1.Create a CIT with noon
with

  "connector_metadata": {
        "noon": {
            "order_category": "pay"
        }
    }
Screenshot 2024-01-12 at 2 16 26 PM without order_category it should throw an error Screenshot 2024-01-12 at 2 16 44 PM
  1. Make a MIT
Screenshot 2024-01-12 at 2 02 35 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari self-assigned this Jan 4, 2024
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Jan 4, 2024
@AkshayaFoiger AkshayaFoiger self-assigned this Jan 12, 2024
@AkshayaFoiger AkshayaFoiger marked this pull request as ready for review January 12, 2024 08:59
@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner January 12, 2024 08:59
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing should be consistent across local DB, the response and the noon dashboard so things like amount validation don't get missed

crates/router/src/connector/noon/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/noon/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/noon/transformers.rs Outdated Show resolved Hide resolved
@swangi-kumari swangi-kumari changed the title refactor: adding new field max_amount to mandate request refactor: [Noon] adding new field max_amount to mandate request Jan 16, 2024
@AkshayaFoiger
Copy link
Contributor

AkshayaFoiger commented Jan 17, 2024

The testing should be consistent across local DB, the response and the noon dashboard so things like amount validation don't get missed

Tested, mandate amount remains consistent in the local DB and dashboard

SamraatBansal
SamraatBansal previously approved these changes Jan 17, 2024
srujanchikke
srujanchikke previously approved these changes Jan 17, 2024
SamraatBansal
SamraatBansal previously approved these changes Jan 17, 2024
@AkshayaFoiger AkshayaFoiger requested review from AkshayaFoiger and removed request for AkshayaFoiger January 17, 2024 10:53
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit eb2a61d Jan 17, 2024
9 checks passed
@likhinbopanna likhinbopanna deleted the noon-fix branch January 17, 2024 12:06
pixincreate added a commit that referenced this pull request Jan 17, 2024
* 'main' of github.com:juspay/hyperswitch:
  refactor: [Noon] adding new field max_amount to mandate request (#3209)
  fix(events): fix event generation for paymentmethods list (#3337)
  chore(router): remove recon from default features (#3370)
  fix(core): add validation for authtype and metadata in update payment connector (#3305)
  refactor(connector): [cybersource] recurring mandate flow (#3354)
  feat(connector_events): added api to fetch connector event logs (#3319)
  feat(payment_method): add capability to store bank details using /payment_methods endpoint (#3113)
@AkshayaFoiger AkshayaFoiger restored the noon-fix branch January 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants