feat(pm_list): add required fields for giropay #3194

AkshayaFoiger · 2023-12-21T15:05:05Z

Type of Change

Description

Resolves #3622

Test Cases

Create a giropay payment with mollie with empty payment method object. The payment should succeed.

{
  "amount": 1000,
  "currency": "EUR",
  "confirm": true,
  "capture_method": "automatic",
  "capture_on": "2022-09-10T10:11:12Z",
  "amount_to_capture": 1000,
  "customer_id": "StripeCustomer",
  "email": "[email protected]",
  "name": "John Doe",
  "phone": "999999999",
  "phone_country_code": "+65",
  "description": "Its my first payment request",
  "authentication_type": "three_ds",
  "return_url": "https://google.com",
  "statement_descriptor_name": "joseph",
  "statement_descriptor_suffix": "JS",
  "payment_method": "bank_redirect",
  "payment_method_type": "giropay",
  "payment_method_data": {
    "bank_redirect": {
      "giropay": {
      }
    }
  }
}

Must be tested for each of this connectors

1.ACI

Required fields: 
    payment_method_data.bank_redirect.giropay.country

Adyen

None

GlobalPayments

Required fields: 
    billing.address.country

Mollie

None

Nuvie

Required fields: 
     email
     billing.address.first_name
     billing.address.last_name
     billing.address.country

Paypal

Required fields: 
     payment_method_data.bank_redirect.giropay.billing_details.billing_name
     payment_method_data.bank_redirect.giropay.country

Shift4

None

Stripe

Required fields 
     payment_method_data.bank_redirect.giropay.billing_details.billing_name

Trustpay

Required fields: 
     billing.address.first_name
     billing.address.line1
     billing.address.city
     billing.address.zip
     billing.address.country

-> Create a payment with confirm false

-> list payment methods, with client secret and publishable key

curl --location 'http://localhost:8080/account/payment_methods?client_secret={{client_secret}}' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:{{api_key}}' \
--data ''

Required fields must be populated, according to the connector

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

prasunna09 · 2023-12-31T07:43:48Z

crates/api_models/src/payments.rs

+        billing_details: Option<BankRedirectBilling>,

        /// The country for bank payment
        #[schema(value_type = CountryAlpha2, example = "US")]
-        country: api_enums::CountryAlpha2,
+        country: Option<api_enums::CountryAlpha2>,

        /// The preferred language
        #[schema(example = "en")]
-        preferred_language: String,
+        preferred_language: Option<String>,


why do we have changes for Sofort pm type in this pr? I observed there was another PR for sofort, please undo these changes if not necessary

Yes, there is another separate PR for Sofort. Sofort changes appeared in this branch as dynamic_field/giropay branch is built upon dynamic_field/sofort branch whilst the PR pointed to main.
Now Sofort changes are removed. Requesting your review

prasunna09 · 2024-01-08T06:57:55Z

crates/router/src/connector/stripe/transformers.rs

+                    .ok_or(errors::ConnectorError::MissingRequiredField {
+                        field_name: "giropay.billing_details",
+                    })?
+                    .billing_name


is billing_name mandatory?
if yes, please use get_billing_name() method from utils to throw the error.

prasunna09 · 2024-01-08T06:59:57Z

crates/router/src/connector/stripe/transformers.rs

+                    country: country
+                        .ok_or(errors::ConnectorError::MissingRequiredField {
+                            field_name: "country",
+                        })?
+                        .to_owned(),


please add utils function get_billing_country for BankRedirectBilling and reuse this function in other places as well

prasunna09 · 2024-01-08T07:01:28Z

crates/router/src/connector/worldline/transformers.rs

+                            .ok_or(errors::ConnectorError::MissingRequiredField {
+                                field_name: "giropay.billing_details",
+                            })?
+                            .billing_name


please use the utils method - get_billing_name() here

prasunna09 · 2024-01-29T07:47:31Z

crates/router/src/configs/defaults.rs

+                                (
+                                    enums::Connector::Adyen,
+                                    RequiredFieldFinal {
+                                        mandate: HashMap::new(),
+                                        non_mandate: HashMap::new(),
+                                        common: HashMap::new(),
+                                    }
+                                ),


if Adyen supports mandates, could you please confirm if this config is present in toml file?

[mandates.supported_payment_methods] bank_redirect.giropay

Could you please check for other connectors?

Adyen supports mandates. I will add it to the config files

Also, make sure you update the env files which is located at https://github.com/juspay/hyperswitch/tree/main/config/deployments

prasunna09 · 2024-02-01T10:50:23Z

crates/router/src/configs/defaults.rs

+                                                "payment_method_data.bank_redirect.giropay.country".to_string(),
+                                                RequiredFieldInfo {
+                                                    required_field: "payment_method_data.bank_redirect.giropay.country".to_string(),
+                                                    display_name: "bank_account_iban".to_string(),


why is the display name bank_account_iban for field country?

It was a typo. Changed it

AkshayaFoiger and others added 9 commits December 21, 2023 13:31

add dynamic fields for sofort aci

bd1c1dc

add dynamic field changes for sofort aci

b3d0f99

add dynamic field changes for sofort aci

dd67fee

add globalpay and mollie dynamic fields for sofort

0bd5824

add dynamic fields for sofort

588c6b3

chore: run formatter

8679744

docs(openapi): re-generate OpenAPI specification

eb36df4

add dynamic fields for aci and adyen giropay

289503c

add dynamic fields for giropay

333ee50

AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes labels Dec 21, 2023

AkshayaFoiger self-assigned this Dec 21, 2023

AkshayaFoiger requested review from a team as code owners December 21, 2023 15:05

hyperswitch-bot bot added 2 commits December 21, 2023 15:05

chore: run formatter

2bfb7ba

docs(openapi): re-generate OpenAPI specification

701affa

prasunna09 reviewed Dec 31, 2023

View reviewed changes

AkshayaFoiger changed the base branch from main to dynamic_field/sofort December 31, 2023 15:14

AkshayaFoiger and others added 2 commits January 1, 2024 18:08

add mandate req field for stripe sofort

e790955

chore: run formatter

678eb53

prasunna09 requested changes Jan 8, 2024

View reviewed changes

AkshayaFoiger and others added 7 commits January 9, 2024 11:15

Merge branch 'main' into dynamic_field/sofort

4c4e0c0

make fields manditory

bd59a2e

Merge branch 'main' into dynamic_field/sofort

3f52d5f

add mandate config and refactor stripe sofort

51fc9a0

refactor stripe transformer

4737bf5

remove extra field

8749233

correct field path

28cb2cd

AkshayaFoiger and others added 2 commits January 18, 2024 18:07

Merge branch 'dynamic_field/sofort' into dynamic_field/giropay

29c16bd

chore: run formatter

3a3585d

AkshayaFoiger added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 18, 2024

ArjunKarthik changed the base branch from dynamic_field/sofort to main January 24, 2024 10:23

Merge branch 'main' into dynamic_field/sofort

c0ccd99

AkshayaFoiger changed the base branch from main to dynamic_field/sofort January 29, 2024 07:38

prasunna09 requested changes Jan 29, 2024

View reviewed changes

make aci country a mandatory field

f8f868d

AkshayaFoiger added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 29, 2024

AkshayaFoiger and others added 2 commits January 29, 2024 13:52

refactor giropay required fields

bdf11fc

Merge branch 'dynamic_field/sofort' into dynamic_field/giropay

f87f157

AkshayaFoiger force-pushed the dynamic_field/giropay branch from 9b18843 to f87f157 Compare January 29, 2024 13:07

add configs

845121c

AkshayaFoiger added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 30, 2024

Base automatically changed from dynamic_field/sofort to main January 30, 2024 09:23

AkshayaFoiger added 2 commits January 31, 2024 14:46

Merge branch 'main' into dynamic_field/giropay

d988c81

Merge branch 'main' into dynamic_field/giropay

d740753

prasunna09 requested changes Feb 1, 2024

View reviewed changes

correct the typo

457bb72

prasunna09 approved these changes Feb 6, 2024

View reviewed changes

ArjunKarthik approved these changes Feb 6, 2024

View reviewed changes

AkshayaFoiger linked an issue Feb 12, 2024 that may be closed by this pull request

[FEATURE] Add required fields for giropay #3622

Closed

2 tasks

likhinbopanna added this pull request to the merge queue Feb 12, 2024

Merged via the queue into main with commit 33df352 Feb 12, 2024
24 of 27 checks passed

likhinbopanna deleted the dynamic_field/giropay branch February 12, 2024 08:10

pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pm_list): add required fields for giropay #3194

feat(pm_list): add required fields for giropay #3194

AkshayaFoiger commented Dec 21, 2023 •

edited

Loading

prasunna09 Dec 31, 2023

AkshayaFoiger Dec 31, 2023 •

edited

Loading

prasunna09 Jan 8, 2024

prasunna09 Jan 8, 2024

prasunna09 Jan 8, 2024

prasunna09 Jan 29, 2024

AkshayaFoiger Jan 29, 2024

pixincreate Jan 29, 2024

prasunna09 Feb 1, 2024

AkshayaFoiger Feb 2, 2024

feat(pm_list): add required fields for giropay #3194

feat(pm_list): add required fields for giropay #3194

Conversation

AkshayaFoiger commented Dec 21, 2023 • edited Loading

Type of Change

Description

Test Cases

Checklist

Choose a reason for hiding this comment

AkshayaFoiger Dec 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshayaFoiger commented Dec 21, 2023 •

edited

Loading

AkshayaFoiger Dec 31, 2023 •

edited

Loading