-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
force-pushed
the
add-metrics-router
branch
from
December 22, 2023 08:08
00be2f1
to
511fdd4
Compare
SanchithHegde
previously approved these changes
Dec 22, 2023
…-router * 'main' of github.com:juspay/hyperswitch: (84 commits) chore(config): add merchant_secret config for webhooks for cashtocode and volt in wasm dashboard (#3333) chore(version): 2024.01.12.0 fix: update amount_capturable based on intent_status and payment flow (#3278) feat: add support for card extended bin in payment attempt (#3312) feat(connector): [cybersource] Implement 3DS flow for cards (#3290) chore: remove connector auth TOML files from `.gitignore` and `.dockerignore` (#3330) fix(refund): add merchant_connector_id in refund (#3303) feat(connector): [BOA/CYB] Store AVS response in connector_metadata (#3271) feat(outgoingwebhookevent): adding api for query to fetch outgoing webhook events log (#3310) feat(router): payment_method block (#3056) feat(connector): [Volt] Add support for refund webhooks (#3326) feat(users): invite user without email (#3328) feat(euclid_wasm): config changes for NMI (#3329) refactor(router): restricted list payment method Customer to api-key based (#3100) feat(connector): [BOA/Cyb] Include merchant metadata in capture and void requests (#3308) fix(router): add config to avoid connector tokenization for `apple pay` `simplified flow` (#3234) refactor(router): flagged order_details validation to skip validation (#3116) fix(core): surcharge with saved card failure (#3318) feat(payment_link): Added sdk layout option payment link (#3207) chore(version): 2024.01.11.0 ...
pixincreate
force-pushed
the
add-metrics-router
branch
from
January 12, 2024 12:35
c3d65b5
to
63ba30c
Compare
…to add-metrics-router * 'add-metrics-router' of github.com:juspay/hyperswitch:
pixincreate
force-pushed
the
add-metrics-router
branch
from
January 12, 2024 13:26
63ba30c
to
3d11f02
Compare
pixincreate
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jan 12, 2024
SanchithHegde
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jan 14, 2024
pixincreate
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Jan 14, 2024
…-router * 'main' of github.com:juspay/hyperswitch: fix(payment_link): added expires_on in payment response (#3332) fix(connector_onboarding): Check if connector exists for the merchant account and add reset tracking id API (#3229) chore(version): 2024.01.12.1 chore: add api reference for blocklist (#3336)
SanchithHegde
previously approved these changes
Jan 16, 2024
Narayanbhat166
approved these changes
Jan 18, 2024
SanchithHegde
approved these changes
Jan 18, 2024
sai-harsha-vardhan
approved these changes
Jan 18, 2024
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jan 18, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 18, 2024
* 'main' of github.com:juspay/hyperswitch: feat(users): Added get role from jwt api (#3385) feat(users): Add `preferred_merchant_id` column and update user details API (#3373) chore(version): 2024.01.18.1 refactor(core): add locker config to enable or disable locker (#3352) fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload (#3382) fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189) fix(connector): Trustpay zen error mapping (#3255) fix(user): fetch profile_id for sample data (#3358) refactor(connector): [Volt] Refactor Payments and Refunds Webhooks (#3377) chore(version): 2024.01.18.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently
TASKS_ADDED_COUNT
andTASKS_RESET_COUNT
metrics does not exist in router to track the tasks added in scheduler. This PR aims at adding that.Closes #2090
Motivation and Context
We need to track the tasks added in scheduler.
How did you test it?
Did a few payments (Ran Stripe and Volt collection a few times):
Local setup:
Modify 3 files:
docker-compose.yml
: Expose theotel-collector
port by replacing"4317"
with"4317:4317"
development.toml
: Enable logging by settingmetrics_enabled
totrue
andotel_exporter_otlp_endpoint
tohttp://localhost:4317
otel-collector.yml
: Add logging in exporters of pipeline service:[prometheus, logging]
instead of[prometheus]
cargo r
curl telnet://localhost:4317
in yet another terminal window to see if this URL can be accessed or notIn env:
Metric:router_TASKS_ADDED_COUNT_total
,label:job=router
>Run Query
Checklist
cargo +nightly fmt --all
cargo clippy