feat(connector): accept connector_transaction_id in error_response of connector flows for Trustpay #3060
Conversation
AkshayaFoiger
added
A-connector-integration
AkshayaFoiger
requested review from
SamraatBansal,
sai-harsha-vardhan and
ArjunKarthik
| } | ||
|
|
||
| #[derive(Deserialize)] | ||
| pub struct TrustPayTransactionStatusErrorResponse { | ||
| pub status: i64, | ||
| pub payment_description: String, | ||
| pub instance_id: Option<String>, |
There was a problem hiding this comment.
This struct is being used in PSync are we getting instance_id in PSync also?
There was a problem hiding this comment.
Yes we are getting instance_id in PSync response
| response | ||
| .payment_information | ||
| .references | ||
| .payment_request_id |
There was a problem hiding this comment.
for bank redirects do we get payment_request_id instead of instance_id?
There was a problem hiding this comment.
Yes we use bank payment_request_id instead of instance_id for bank redirects. Ref page.no 333 of trustpay.rs
| @@ -1637,16 +1647,19 @@ pub struct Errors { | |||
| } | |||
|
|
|||
| #[derive(Default, Debug, Serialize, Deserialize, PartialEq)] | |||
| #[serde(rename_all = "camelCase")] | |||
There was a problem hiding this comment.
Can you confirm TrustPayTransactionStatusErrorResponse also requires camelCase
There was a problem hiding this comment.
Yes the struct TrustPayTransactionStatusErrorResponse is required to be a camelCase
| pub struct TrustpayErrorResponse { | ||
| pub status: i64, | ||
| pub description: Option<String>, | ||
| pub errors: Option<Vec<Errors>>, | ||
| pub instance_id: Option<String>, |
There was a problem hiding this comment.
We shouldn't get instance_id for bank redirects failures right?
There was a problem hiding this comment.
yes instance_id is not provided during all error scenarios.
SanchithHegde
removed
the
S-waiting-on-review
Type of Change
Description
Resolves #3543
How did you test it?
Test card number
4200 0000 0000 002for further test cards, refer here
Expected behavior :
connector_transaction_idshould be populatedconnector_transaction_idshould be populated (Note: For some types error, connector transaction id will not be sent by the connector)Checklist
cargo +nightly fmt --allcargo clippy