Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove error propagation if card name not found in locker #3059

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: remove error propagation if card name not found in locker #3059

merged 1 commit into from
Dec 5, 2023

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Dec 5, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR removes the error propagation if card name not found in locker. Instead asks during confirm flow
Original PR - #2998

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added the C-bug Category: Bug label Dec 5, 2023
@Chethan-rao Chethan-rao added this to the December 2023 Release milestone Dec 5, 2023
@Chethan-rao Chethan-rao self-assigned this Dec 5, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner December 5, 2023 14:17
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 5, 2023
@Chethan-rao Chethan-rao changed the title remove error propagation if card_holder_name not found during confirm fix: remove error propagation if card name not found in locker Dec 5, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 5, 2023
@SanchithHegde SanchithHegde merged commit 9e4999b into hotfix-1.89.0 Dec 5, 2023
14 of 22 checks passed
@SanchithHegde SanchithHegde deleted the fix-for-card-name branch December 5, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Chethan-rao Chethan-rao

Labels
C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Chethan-rao @SanchithHegde @vspecky