-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(user): add email apis and new enums for metadata #3053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor concerns. Other than that LGTM.
crates/router/Cargo.toml
Outdated
@@ -9,7 +9,7 @@ readme = "README.md" | |||
license.workspace = true | |||
|
|||
[features] | |||
default = ["kv_store", "stripe", "oltp", "olap", "backwards_compatibility", "accounts_cache", "dummy_connector", "payouts", "profile_specific_fallback_routing", "retry"] | |||
default = ["kv_store", "stripe", "oltp", "olap", "backwards_compatibility", "accounts_cache", "dummy_connector", "payouts", "profile_specific_fallback_routing", "retry", "email"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we enabling email by default? Is this intentional?
is_email_sent, | ||
})) | ||
} else { | ||
Err(UserErrors::InternalServerError.into()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err(UserErrors::InternalServerError.into()) | |
invitee_user.change_context(UserErrors::InternalServerError)? |
This way the error will be propagated.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Dashboard Metadata new enums
Get Dashboard metadata for new enums:
Set Dashboard Metadata for new enums:
For refund
Dynamic search for payment_id or refund_id:
Refund_status Bugfix:
Checklist
cargo +nightly fmt --all
cargo clippy