Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform connector name to lowercase in connector integration script #3048

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: transform connector name to lowercase in connector integration script #3048

merged 1 commit into from
Dec 4, 2023

Conversation

SamraatBansal
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

transform connector name to lowercase in the add_connector script.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

created a new connector and discarded it works. Need not to be tested by QA

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 4, 2023
@SamraatBansal SamraatBansal self-assigned this Dec 4, 2023
@SamraatBansal SamraatBansal requested a review from a team as a code owner December 4, 2023 10:39
@SanchithHegde SanchithHegde changed the title fix: transform connector name to lowercase fix: transform connector name to lowercase in connector integration script Dec 4, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 298e362 Dec 4, 2023
12 of 14 checks passed
@SanchithHegde SanchithHegde deleted the update-connector-script branch December 4, 2023 20:31
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamraatBansal @jagan-jaya @SanchithHegde