Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): accept connector_transaction_id in error_response of connector flows for Cybersource and BOA #3043

Closed
wants to merge 11 commits into from
Closed

feat(connector): accept connector_transaction_id in error_response of connector flows for Cybersource and BOA #3043

wants to merge 11 commits into from

Conversation

AkshayaFoiger
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger commented Dec 4, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves #3504

How did you test it?

BOA failed payment
Screenshot 2023-12-04 at 1 23 56 PM

Cybersource failed payment
Screenshot 2023-12-04 at 8 21 57 PM

Screenshot 2023-12-04 at 8 22 00 PM

Auth id stored in connector metadata for manual authorization call

Screenshot 2023-12-13 at 2 42 58 PM

Test Cases

  1. Create a failed payment with Cybersource, connector_transaction_id must be populated
  2. Create a failed payment with BOA, connector_transaction_id must be populated

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner December 4, 2023 07:55
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 4, 2023
@AkshayaFoiger AkshayaFoiger self-assigned this Dec 4, 2023
@AkshayaFoiger AkshayaFoiger added C-feature Category: Feature request or enhancement and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Dec 4, 2023
@AkshayaFoiger AkshayaFoiger changed the title [FEATURE] accept connector_transaction_id in error_response of connector flows for Cybersource and BOA feat(connector): accept connector_transaction_id in error_response of connector flows for Cybersource and BOA Dec 4, 2023
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 4, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Dec 4, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Dec 5, 2023
@AkshayaFoiger AkshayaFoiger added S-wont-fix Status: The proposal in this issue was rejected and will not be implemented S-blocked Status: Blocked on something else or other implementation work and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Dec 18, 2023
@SanchithHegde SanchithHegde deleted the connector_transaction_id/cybersource branch January 1, 2024 16:47
@SanchithHegde SanchithHegde removed S-blocked Status: Blocked on something else or other implementation work S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-wont-fix Status: The proposal in this issue was rejected and will not be implemented labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik left review comments

@deepanshu-iiitu deepanshu-iiitu Awaiting requested review from deepanshu-iiitu

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Code Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkshayaFoiger @ArjunKarthik @SanchithHegde