docs(connector): update connector integration documentation #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
srujanchikke
changed the title
add_connector.md file add_connector.md document
srujanchikke
changed the title
add_connector.md document
srujanchikke
changed the title
Signed-off-by: chikke srujan <[email protected]>
SanchithHegde
previously approved these changes
Dec 5, 2023
add_connector.md
Outdated
Comment on lines
351
to
353
| let redirection_data = item.response.links.redirect.map(|href| { | ||
| services::RedirectForm::from((href.redirection_url, services::Method::Get)) | ||
| }); |
There was a problem hiding this comment.
Can we format the Rust code snippets included in this document?
add_connector.md
Outdated
| ``` | ||
|
|
||
| **ConnectorIntegration :** For every api endpoint contains the url, using request transform and response transform and headers. | ||
| Within the `ConnectorIntegration` trait, you'll find the following methods implemented(below mentioned is example for authorized flow ): |
There was a problem hiding this comment.
Suggested change
| Within the `ConnectorIntegration` trait, you'll find the following methods implemented(below mentioned is example for authorized flow ): | |
| Within the `ConnectorIntegration` trait, you'll find the following methods implemented (below mentioned is example for authorized flow): |
add_connector.md
Outdated
| } | ||
| ``` | ||
|
|
||
| - `get_request_body` method calls transformers where hyperswitch payment request data is transformed into connector payment request .For constructing the request body have a function `log_and_get_request_body` that allows generic argument which is the struct that is passed as the body for connector integration, and a function that can be use to encode it into String. We log the request in this function, as the struct will be intact and the masked values will be masked. |
There was a problem hiding this comment.
Suggested change
| - `get_request_body` method calls transformers where hyperswitch payment request data is transformed into connector payment request .For constructing the request body have a function `log_and_get_request_body` that allows generic argument which is the struct that is passed as the body for connector integration, and a function that can be use to encode it into String. We log the request in this function, as the struct will be intact and the masked values will be masked. | |
| - `get_request_body` method calls transformers where hyperswitch payment request data is transformed into connector payment request. For constructing the request body have a function `log_and_get_request_body` that allows generic argument which is the struct that is passed as the body for connector integration, and a function that can be use to encode it into String. We log the request in this function, as the struct will be intact and the masked values will be masked. |
Please ensure correct punctuation across the document.
SanchithHegde
approved these changes
Dec 17, 2023
ArjunKarthik
approved these changes
Dec 19, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
As
add_connector.mdwas updated long time ago, This PR updates theadd_connector.mdfile.Additional Changes
Motivation and Context
How did you test it?
No tests required as this is documentation related PR.
Checklist
cargo +nightly fmt --allcargo clippy