Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: calculate surcharge for customer saved card list #3039

Merged
merged 23 commits into from
Dec 4, 2023
Merged

feat: calculate surcharge for customer saved card list #3039

merged 23 commits into from
Dec 4, 2023

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Calculate surcharge for saved cards in list_customer_payment_methods call and store in redis for use in confirm flow.

  • Remove all surcharge validations in confirm flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 3, 2023
@hrithikesh026 hrithikesh026 self-assigned this Dec 3, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners December 3, 2023 06:27
@hrithikesh026 hrithikesh026 changed the base branch from main to surcharge-api-model-changes December 4, 2023 08:09
@Narayanbhat166 Narayanbhat166 changed the base branch from surcharge-api-model-changes to use-card-bin December 4, 2023 10:18
@hrithikesh026 hrithikesh026 requested a review from jarnura December 4, 2023 11:00
Narayanbhat166
Narayanbhat166 reviewed Dec 4, 2023
View reviewed changes
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/router/src/openapi.rs Outdated Show resolved Hide resolved
Narayanbhat166
Narayanbhat166 previously approved these changes Dec 4, 2023
View reviewed changes
vspecky
vspecky previously approved these changes Dec 4, 2023
View reviewed changes
Base automatically changed from use-card-bin to main December 4, 2023 14:35
@likhinbopanna likhinbopanna dismissed stale reviews from vspecky and Narayanbhat166 December 4, 2023 14:35

The base branch was changed.

@bernard-eugine bernard-eugine merged commit daf0f09 into main Dec 4, 2023
9 of 12 checks passed
@bernard-eugine bernard-eugine deleted the surcharge-genration-for-saved-card branch December 4, 2023 17:00
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@hrithikesh026 hrithikesh026

Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hrithikesh026 @vspecky @Narayanbhat166 @SanchithHegde @bernard-eugine