feat(router): add payments incremental authorization api #3038

sai-harsha-vardhan · 2023-12-02T16:25:55Z

Type of Change

Description

add payments incremental authorization api and add support for cybersource connector

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

send request_incremental_authorization as false in payments request, to see incremental_authorization_allowed being sent as false in response
now, try doing an increment authorization for the above payment to see not allowed error
CURL
curl --location --request POST '{baseUrl}/payments/{payment_id}/incremental_authorization' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: {API_KEY}' \ --data-raw '{ "amount": 11005 }'
try sending request_incremental_authorization as true for payment for which capture_method is automatic to see not allowed error
now send request_incremental_authorization as true for payment with capture_method manual to see incremental_authorization_allowed being true in response
now, for above payment_id try doing an increment authorization with amount less than original amount to see now allowed error
now, do the increment authorization with amount greater than original amount to see final authorized amount
all the authorization details along with authorization_count can be seen in the response

retrieve the payment to see authorization details

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

…_allowed

…om:juspay/hyperswitch into add-core-changes-incremental-authorization

Narayanbhat166 · 2023-12-03T15:25:04Z

crates/api_models/src/payments.rs

+    pub code: Option<String>,
+    pub message: Option<String>,


Is this only for error_code and error_message, or some other code and message value can be present here? Can you also add doc comments to the fields?

This can be any code and message sent by connector

crates/diesel_models/src/payment_attempt.rs

crates/diesel_models/src/payment_intent.rs

Narayanbhat166 · 2023-12-03T18:57:58Z

migrations/2023-12-01-090834_add-authorization_count-in-payment_intent/up.sql

@@ -0,0 +1,2 @@
+-- Your SQL goes here
+ALTER TABLE payment_intent ADD COLUMN IF NOT EXISTS authorization_count INTEGER;


All the previous payments should have this value as zero, will adding a default as 0 help?

This is to distinguish for normal payments with incremental auth performed payments

Narayanbhat166 · 2023-12-04T06:29:51Z

crates/router/src/db/authorization.rs

+        &self,
+        _authorization: storage::AuthorizationNew,
+    ) -> CustomResult<storage::Authorization, errors::StorageError> {
+        // TODO: Implement function for `MockDb`


Can you create good first issues for these? The issue can be linked to the parent issue #172

Narayanbhat166 · 2023-12-04T06:31:10Z

crates/router/src/db/authorization.rs

+    async fn find_all_authorizations_by_merchant_id_payment_id(
+        &self,
+        merchant_id: &str,
+        payment_id: &str,
+    ) -> CustomResult<Vec<storage::Authorization>, errors::StorageError> {
+        let conn = connection::pg_connection_read(self).await?;
+        storage::Authorization::find_by_merchant_id_payment_id(&conn, merchant_id, payment_id)
+            .await
+            .map_err(Into::into)
+            .into_report()
+    }


This should be an olap operation, can you include the feature flag?

We are using this in get_trackers of PaymentsRetrieve

Narayanbhat166 · 2023-12-04T06:42:58Z

crates/router/src/core/payments/operations/payment_response.rs

+        Box::pin(payment_response_update_tracker(
+            db,
+            payment_id,
+            payment_data,
+            router_data,
+            storage_scheme,
+        ))
+        .await
+    }


Can you have a separate post_update_tracker for this operation? Adding all of the update trackers in a single functions makes it bloated.

Narayanbhat166 · 2023-12-04T06:48:27Z

crates/router/src/core/payments/operations/payments_incremental_authorization.rs

+            .store
+            .insert_authorization(authorization_new.clone())
+            .await
+            .to_not_found_response(errors::ApiErrorResponse::InternalServerError)


This should be to_duplicate_response, and the error can be GenericDuplicateError

…ntal-authorization-api

…/hyperswitch into add-incremental-authorization-api

Narayanbhat166 · 2023-12-04T11:58:41Z

crates/router/src/core/payments/operations/payment_response.rs

+                error_code,
+                error_message,


why will a success response have error code and message?

In case of 2xx failures, we need error_code and error_message in IncrementalAuthorizationResponse

Narayanbhat166 · 2023-12-04T12:00:06Z

crates/router/src/core/payments/operations/payment_response.rs

+        let authorizations = db
+            .store
+            .find_all_authorizations_by_merchant_id_payment_id(
+                &router_data.merchant_id,
+                &payment_data.payment_intent.payment_id,
+            )
+            .await
+            .to_not_found_response(errors::ApiErrorResponse::InternalServerError)
+            .attach_printable("failed while retrieving authorizations")?;


Is this to update the status of latest authorization?

No, this is to fetch all the authorizations and send back in the incremental auth response

deepanshu-iiitu

Cybersource changes look good.

Narayanbhat166 · 2023-12-04T12:10:39Z

crates/router/src/core/payments/operations/payment_response.rs

+            incremental_authorization_allowed: if payment_data
+                .incremental_authorization_details
+                .is_none()
+            {
+                Some(false)
+            } else {
+                None
+            },


Can you remove this?

ArjunKarthik

@sai-harsha-vardhan I reviewed connector code, it looks good to me

sai-harsha-vardhan and others added 6 commits November 29, 2023 14:06

make core changes in payments flow to support incremental authorization

39265ea

docs(openapi): re-generate OpenAPI specification

17d59d7

check request_incremental_authorization for incremental_authorization…

a21d9aa

…_allowed

Merge branch 'add-core-changes-incremental-authorization' of github.c…

11fb658

…om:juspay/hyperswitch into add-core-changes-incremental-authorization

resolve conflicts

04e74a7

add incremental authorization api

a8df3b3

sai-harsha-vardhan added this to the November 2023 Release milestone Dec 2, 2023

sai-harsha-vardhan requested review from ArjunKarthik, SanchithHegde and Narayanbhat166 December 2, 2023 16:25

sai-harsha-vardhan self-assigned this Dec 2, 2023

sai-harsha-vardhan requested review from a team as code owners December 2, 2023 16:25

sai-harsha-vardhan added 2 commits December 2, 2023 22:19

resolve conflicts

9e97b46

fix openapi

fcdc016

sai-harsha-vardhan changed the title ~~feat(router): add incremental authorization api~~ feat(router): add payments incremental authorization api Dec 2, 2023

Narayanbhat166 reviewed Dec 3, 2023

View reviewed changes

Narayanbhat166 reviewed Dec 4, 2023

View reviewed changes

sai-harsha-vardhan and others added 2 commits December 4, 2023 13:48

resolve comments

c560b3d

Merge branch 'main' into add-incremental-authorization-api

07dbd49

sai-harsha-vardhan requested a review from Narayanbhat166 December 4, 2023 09:02

resolve comments

461ab30

sai-harsha-vardhan and others added 6 commits December 4, 2023 16:44

Merge branch 'main' of github.com:juspay/hyperswitch into add-increme…

37a8bc3

…ntal-authorization-api

Merge branch 'add-incremental-authorization-api' of github.com:juspay…

9c8ef52

…/hyperswitch into add-incremental-authorization-api

change authorization_status from created to processing

c31712e

docs(openapi): re-generate OpenAPI specification

ebbfea6

change authorizedpendingreview in cybs to success authorization staus

83bf946

Merge branch 'add-incremental-authorization-api' of github.com:juspay…

4a3adf5

…/hyperswitch into add-incremental-authorization-api

sai-harsha-vardhan requested a review from deepanshu-iiitu December 4, 2023 11:58

Narayanbhat166 reviewed Dec 4, 2023

View reviewed changes

deepanshu-iiitu previously approved these changes Dec 4, 2023

View reviewed changes

Narayanbhat166 reviewed Dec 4, 2023

View reviewed changes

resolve comments

4408149

sai-harsha-vardhan dismissed deepanshu-iiitu’s stale review via 4408149 December 4, 2023 12:13

sai-harsha-vardhan requested review from Narayanbhat166 and deepanshu-iiitu December 4, 2023 12:15

Narayanbhat166 approved these changes Dec 4, 2023

View reviewed changes

deepanshu-iiitu approved these changes Dec 4, 2023

View reviewed changes

likhinbopanna added this pull request to the merge queue Dec 4, 2023

ArjunKarthik approved these changes Dec 4, 2023

View reviewed changes

Merged via the queue into main with commit a0cfdd3 Dec 4, 2023
10 of 12 checks passed

likhinbopanna deleted the add-incremental-authorization-api branch December 4, 2023 13:18

pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(router): add payments incremental authorization api #3038

feat(router): add payments incremental authorization api #3038

sai-harsha-vardhan commented Dec 2, 2023 •

edited

Loading

Narayanbhat166 Dec 3, 2023

sai-harsha-vardhan Dec 4, 2023

Narayanbhat166 Dec 3, 2023

sai-harsha-vardhan Dec 4, 2023

Narayanbhat166 Dec 4, 2023

sai-harsha-vardhan Dec 4, 2023

Narayanbhat166 Dec 4, 2023

sai-harsha-vardhan Dec 4, 2023

Narayanbhat166 Dec 4, 2023

Narayanbhat166 Dec 4, 2023

Narayanbhat166 Dec 4, 2023

sai-harsha-vardhan Dec 4, 2023

Narayanbhat166 Dec 4, 2023

sai-harsha-vardhan Dec 4, 2023

deepanshu-iiitu left a comment

Narayanbhat166 Dec 4, 2023

ArjunKarthik left a comment

		@@ -0,0 +1,2 @@
		-- Your SQL goes here
		ALTER TABLE payment_intent ADD COLUMN IF NOT EXISTS authorization_count INTEGER;

feat(router): add payments incremental authorization api #3038

feat(router): add payments incremental authorization api #3038

Conversation

sai-harsha-vardhan commented Dec 2, 2023 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepanshu-iiitu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArjunKarthik left a comment

Choose a reason for hiding this comment

sai-harsha-vardhan commented Dec 2, 2023 •

edited

Loading