Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use card bin to get additional card details #3036

Merged
merged 13 commits into from
Dec 4, 2023
Merged

fix: use card bin to get additional card details #3036

merged 13 commits into from
Dec 4, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Dec 2, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • If few card parameters are missing in payment create or confirm call, populate them from card_bin.
  • Remove surcharge validation in payment_confirm flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 2, 2023
@hrithikesh026 hrithikesh026 self-assigned this Dec 2, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners December 2, 2023 08:55
@hrithikesh026 hrithikesh026 changed the base branch from main to surcharge-api-model-changes December 4, 2023 05:55
@hrithikesh026 hrithikesh026 changed the base branch from surcharge-api-model-changes to main December 4, 2023 05:57
@hrithikesh026 hrithikesh026 changed the base branch from main to surcharge-api-model-changes December 4, 2023 07:45
Narayanbhat166
Narayanbhat166 previously approved these changes Dec 4, 2023
View reviewed changes
vspecky
vspecky previously approved these changes Dec 4, 2023
View reviewed changes
Base automatically changed from surcharge-api-model-changes to main December 4, 2023 11:54
@likhinbopanna likhinbopanna dismissed stale reviews from vspecky and Narayanbhat166 December 4, 2023 11:54

The base branch was changed.

@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 6c7d3a2 Dec 4, 2023
14 of 16 checks passed
@likhinbopanna likhinbopanna deleted the use-card-bin branch December 4, 2023 14:35
@Gnanasundari24 Gnanasundari24 mentioned this pull request Dec 7, 2023
Merged
15 tasks
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hrithikesh026 @vspecky @Narayanbhat166 @SanchithHegde @likhinbopanna