Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add drainer delay metric #3034

Merged
merged 4 commits into from
Dec 6, 2023
Merged

feat(metrics): add drainer delay metric #3034

merged 4 commits into from
Dec 6, 2023

Conversation

dracarys18
Copy link
Member

Type of Change

  • New feature

Description

Added delay metric to drainer.

Motivation and Context

Added a delay metric to drainer to calculate delay between when data was pushed to drainer and when it was drained.

How did you test it?

  • Create a payment and check the drainer metrics.
  • Query this in grafana with vm-single as the data source
histogram_quantile(0.99, sum by(le, operation) (rate(router_DRAINER_DELAY_SECONDS_bucket{app_name="router"}[$__rate_interval])))
Screenshot 2023-12-01 at 6 59 03 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 1, 2023
@dracarys18 dracarys18 added this to the November 2023 Release milestone Dec 1, 2023
@dracarys18 dracarys18 self-assigned this Dec 1, 2023
@dracarys18 dracarys18 requested a review from a team as a code owner December 1, 2023 13:31
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit c6e2ee2 Dec 6, 2023
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the add_drainer_delay_metric branch December 6, 2023 06:08
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-97 akshay-97 akshay-97 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@dracarys18 dracarys18

Labels
A-core Area: Core flows
Projects
None yet
Milestone
December 2023 Release
Development

Successfully merging this pull request may close these issues.
6 participants
@dracarys18 @jarnura @akshay-97 @SanchithHegde @bernard-eugine @likhinbopanna