Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): add kms decryption support for sqlx password #3029

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(config): add kms decryption support for sqlx password #3029

merged 1 commit into from
Dec 1, 2023

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Dec 1, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Allow kms decryption for Analytics SQLX password when the kms feature flag is enabled

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • run it with the KMS feature flag & provide kms encrypted values

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added A-infra Area: Infrastructure C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 1, 2023
@lsampras lsampras self-assigned this Dec 1, 2023
@lsampras lsampras requested a review from a team as a code owner December 1, 2023 07:16
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 1, 2023
@pixincreate pixincreate enabled auto-merge December 1, 2023 07:29
@pixincreate pixincreate added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit b593467 Dec 1, 2023
10 of 12 checks passed
@pixincreate pixincreate deleted the sqlx_kms_decrypt branch December 1, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-sharma-juspay harsh-sharma-juspay harsh-sharma-juspay approved these changes

@ShivanshMathurJuspay ShivanshMathurJuspay ShivanshMathurJuspay approved these changes

@pixincreate pixincreate pixincreate approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@lsampras lsampras

Labels
A-infra Area: Infrastructure C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lsampras @SanchithHegde @pixincreate @ShivanshMathurJuspay @harsh-sharma-juspay