-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add fallback to reverselookup error #3025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Nov 30, 2023
jarnura
reviewed
Dec 1, 2023
jarnura
reviewed
Dec 1, 2023
…ch into reverse_lookup_fallback
akshay-97
previously approved these changes
Dec 1, 2023
jarnura
previously approved these changes
Dec 4, 2023
akshay-97
approved these changes
Dec 4, 2023
jarnura
approved these changes
Dec 4, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Motivation and Context
For the old data's which are created with
PostgresOnly
will not have a Reverselookup inserted so if you try to fetch it , It will throw an error. So added a fallback to account for such cases it should directly go to the DB implementation of the function.How did you test it?
KV
disabled in the merchant.Checklist
cargo +nightly fmt --all
cargo clippy