Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): fix wasm function to return the categories for keys with their description respectively #3023

Merged
merged 3 commits into from
Dec 1, 2023
Merged

fix(wasm): fix wasm function to return the categories for keys with their description respectively #3023

merged 3 commits into from
Dec 1, 2023

Conversation

Aprabhat19
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fix wasm function to return the categories for keys with their description respectively

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

This PR adds changes to a wasm function , couldn't be tested

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Aprabhat19 Aprabhat19 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-routing Area: Routing labels Nov 30, 2023
@Aprabhat19 Aprabhat19 self-assigned this Nov 30, 2023
@Aprabhat19 Aprabhat19 requested a review from a team as a code owner November 30, 2023 12:59
@Aprabhat19 Aprabhat19 requested review from vspecky and a team November 30, 2023 13:04
@preetamrevankar preetamrevankar added this pull request to the merge queue Dec 1, 2023
@lsampras lsampras removed this pull request from the merge queue due to a manual request Dec 1, 2023
@lsampras lsampras changed the title fix(was): fix wasm function to return the categories for keys with their description respectively fix(wasm): fix wasm function to return the categories for keys with their description respectively Dec 1, 2023
@lsampras lsampras enabled auto-merge December 1, 2023 07:58
@lsampras lsampras added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 2ac5b2c Dec 1, 2023
12 of 14 checks passed
@lsampras lsampras deleted the fix-category-desc branch December 1, 2023 08:15
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@vspecky vspecky vspecky approved these changes

Assignees

@Aprabhat19 Aprabhat19

Labels
A-routing Area: Routing C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Aprabhat19 @vspecky @prajjwalkumar17 @lsampras @SanchithHegde