Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: few fields were not getting updated in apply_changeset function #3002

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: few fields were not getting updated in apply_changeset function #3002

merged 2 commits into from
Nov 29, 2023

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In fn apply_changeset() function, which is being used in KV for applying the changed fields was not updating all the fields.
Fixed it.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Cannot be tested in local

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 28, 2023
@hrithikesh026 hrithikesh026 added this to the November 2023 Release milestone Nov 28, 2023
@hrithikesh026 hrithikesh026 self-assigned this Nov 28, 2023
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner November 28, 2023 15:18
jarnura
jarnura previously approved these changes Nov 29, 2023
View reviewed changes
vspecky
vspecky requested changes Nov 29, 2023
View reviewed changes
crates/diesel_models/src/business_profile.rs Outdated Show resolved Hide resolved
crates/diesel_models/src/capture.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit d289524 Nov 29, 2023
9 of 12 checks passed
@SanchithHegde SanchithHegde deleted the fix-kv-update-field branch November 29, 2023 08:42
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug
Projects
None yet
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@hrithikesh026 @jarnura @SanchithHegde @vspecky