Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add key_value to locker metrics #2995

Merged
merged 8 commits into from
Dec 4, 2023
Merged

feat(router): add key_value to locker metrics #2995

merged 8 commits into from
Dec 4, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add key_vaule to locker metrics to identify the request made to different locker (Rust or Basilisk HS).

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Testing is not required as this is just updating the key_value of the existing locker metrics.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 28, 2023
@ShankarSinghC ShankarSinghC added this to the November 2023 Release milestone Nov 28, 2023
@ShankarSinghC ShankarSinghC self-assigned this Nov 28, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner November 28, 2023 10:17
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 28, 2023
@ShankarSinghC ShankarSinghC changed the title enhancement(router): add key_vaule to locker metrics enhancement(router): add key_value to locker metrics Nov 28, 2023
@ShankarSinghC ShankarSinghC changed the title enhancement(router): add key_value to locker metrics feat(router): add key_value to locker metrics Nov 28, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 28, 2023
NishantJoshi00
NishantJoshi00 requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@NishantJoshi00 NishantJoshi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is no counter to know successful addition, can we add that metric with appropriate attributes?

@ShankarSinghC ShankarSinghC requested a review from a team as a code owner November 29, 2023 06:44
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 83fcd1a Dec 4, 2023
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the add-key-value-locker branch December 4, 2023 07:04
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhinbopanna likhinbopanna likhinbopanna approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ShankarSinghC @NishantJoshi00 @sai-harsha-vardhan @likhinbopanna @SanchithHegde