Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: surcharge related status and rules fix #2974

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix

Description

List of bug fixed in this PR.

  1. The surcharge rules set for the card networks is not applied.
  2. After confirming a payment with a surcharge through the TrustPay connector for card payments, the payment status is showing as a partial capture instead of succeeded.
  3. Made paypal postman collection changes.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual
Screenshot 2023-11-24 at 1 01 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 24, 2023
@hrithikesh026 hrithikesh026 added this to the November 2023 Release milestone Nov 24, 2023
@hrithikesh026 hrithikesh026 self-assigned this Nov 24, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners November 24, 2023 08:11
Copy link
Member

@vspecky vspecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card network fix in euclid is not here. please add it as well.

vspecky
vspecky previously approved these changes Nov 24, 2023
@bernard-eugine bernard-eugine merged commit 3db7213 into main Nov 24, 2023
8 of 11 checks passed
@bernard-eugine bernard-eugine deleted the surcharge-related-status-fix branch November 24, 2023 13:14
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants