Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement FRM flows #2968

Merged
merged 16 commits into from
Dec 5, 2023
Merged

feat: implement FRM flows #2968

merged 16 commits into from
Dec 5, 2023

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Nov 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR implements FRM functionality.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested locally using FRM postman suite.

Postman suite for testing
https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-f089414f-3188-4c38-8a0d-198956e9e252?action=share&creator=9906252

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m self-assigned this Nov 23, 2023
@kashif-m kashif-m requested review from a team as code owners November 23, 2023 12:05
@SanchithHegde SanchithHegde changed the title refactor: move FRM to OSS feature: implement FRM flows Nov 23, 2023
@SanchithHegde SanchithHegde changed the title feature: implement FRM flows feat: implement FRM flows Nov 23, 2023
@github-actions github-actions bot added S-conventions-not-followed Status: This PR does not follow contributing guidelines and removed S-conventions-not-followed Status: This PR does not follow contributing guidelines labels Nov 23, 2023
@kashif-m kashif-m requested a review from jagan-jaya November 29, 2023 10:53
@kashif-m kashif-m added the C-feature Category: Feature request or enhancement label Nov 29, 2023
@kashif-m kashif-m added this to the November 2023 Release milestone Nov 29, 2023
@kashif-m kashif-m added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 29, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Dec 1, 2023
View reviewed changes
AkshayaFoiger
AkshayaFoiger previously approved these changes Dec 1, 2023
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Dec 4, 2023
View reviewed changes
crates/router/src/configs/settings.rs Outdated Show resolved Hide resolved
crates/router/src/connector/signifyd/transformers/api.rs Outdated Show resolved Hide resolved
crates/router/src/core/fraud_check.rs Outdated Show resolved Hide resolved
crates/router/src/core/fraud_check.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/flows.rs Outdated Show resolved Hide resolved
crates/router_env/src/logger/types.rs Outdated Show resolved Hide resolved
AkshayaFoiger
AkshayaFoiger previously approved these changes Dec 4, 2023
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Dec 5, 2023
View reviewed changes
AkshayaFoiger
AkshayaFoiger previously approved these changes Dec 5, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik previously approved these changes Dec 5, 2023
View reviewed changes
@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 055d838 Dec 5, 2023
10 of 12 checks passed
@SanchithHegde SanchithHegde deleted the frm_oss branch December 5, 2023 13:05
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

Assignees

@kashif-m kashif-m

Labels
C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@kashif-m @ArjunKarthik @SanchithHegde @AkshayaFoiger