fix(router): added validation to check total orderDetails amount equal to amount in request

[sahkal]

added validation to check total orderDetails amount equal to amount in request

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Added validation to check total orderDetails amount equal to amount in request.

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Test cases

1. Where amount and total amount in orderDetails doesn't match.

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_6B2gnO7ZTbAitEgXrQDRsfJVvu6tp98HnNaSGvY8rvIoXwpzn2RALy4TgUiXMqhc' \
--data '{
    "amount": 40,
    "currency": "USD",
    "confirm": false,
    "customer_id": "sahkal",
    "return_url": "https://google.com",
    "description": "For selling Tea",
    "order_details": [
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": null
        },
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        }
    ]
}'

2 . Total amount is not provided but order details object is provided

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_6B2gnO7ZTbAitEgXrQDRsfJVvu6tp98HnNaSGvY8rvIoXwpzn2RALy4TgUiXMqhc' \
--data '{
    "currency": "USD",
    "confirm": false,
    "customer_id": "sahkal",
    "return_url": "https://google.com",
    "description": "For selling Tea",
    "order_details": [
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": null
        },
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        }
    ]
 }'

3. Where amount and total amount in orderDetails match

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_6B2gnO7ZTbAitEgXrQDRsfJVvu6tp98HnNaSGvY8rvIoXwpzn2RALy4TgUiXMqhc' \
--data '{
    "amount": 20,
    "currency": "USD",
    "confirm": false,
    "customer_id": "sahkal",
    "return_url": "https://google.com",
    "description": "For selling Tea",
    "order_details": [
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": null
        },
        {
            "product_name": "Tea",
            "quantity": 1,
            "amount": 10,
            "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg"
        }
    ]
}'

4. where only Amount is provided without orderDetails

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_6B2gnO7ZTbAitEgXrQDRsfJVvu6tp98HnNaSGvY8rvIoXwpzn2RALy4TgUiXMqhc' \
--data '{
    "amount": 20,
    "currency": "USD",
    "confirm": false,
    "customer_id": "sahkal",
    "return_url": "https://google.com",
    "description": "For selling Tea"
}'

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

[sai-harsha-vardhan]

Can you please add this validation in payments update flow too?

[Narayanbhat166]

the amount is mandated in confirm flow, this should not be the case