-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): add type info to outgoing requests & maintain structural & PII type info #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsampras
added
A-framework
Area: Framework
C-feature
Category: Feature request or enhancement
labels
Nov 22, 2023
…erasedmaskserialize
NishantJoshi00
requested changes
Dec 11, 2023
ArjunKarthik
requested changes
Dec 12, 2023
ArjunKarthik
added
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Dec 12, 2023
ArjunKarthik
previously approved these changes
Dec 12, 2023
NishantJoshi00
previously approved these changes
Dec 12, 2023
ThisIsMani
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed dashboard specific changes.
lsampras
removed
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Dec 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2023
lsampras
dismissed stale reviews from ThisIsMani, NishantJoshi00, and ArjunKarthik
via
December 12, 2023 12:38
d02ee42
SanchithHegde
approved these changes
Dec 13, 2023
ThisIsMani
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
send_request
function and theRequest
object to send outgoing api callsAdditional Changes
Motivation and Context
Future enhancements
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy