-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(users): Separate signup and signin #2921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
A-users
Area: Users
labels
Nov 20, 2023
apoorvdixit88
previously approved these changes
Nov 20, 2023
lsampras
previously approved these changes
Nov 20, 2023
racnan
reviewed
Nov 20, 2023
Comment on lines
+20
to
+22
let user_from_db = new_user | ||
.insert_user_and_merchant_in_db(state.clone()) | ||
.await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine with above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't be combined because the above function doesn't return UserFromStorage
.
ThisIsMani
dismissed stale reviews from lsampras and apoorvdixit88
via
November 20, 2023 13:33
cd43bfe
ThisIsMani
force-pushed
the
signup-signin
branch
from
December 4, 2023 04:23
fbccb7d
to
f409bea
Compare
…f user and user_role
racnan
approved these changes
Dec 4, 2023
apoorvdixit88
approved these changes
Dec 4, 2023
NishantJoshi00
approved these changes
Dec 4, 2023
Narayanbhat166
approved these changes
Dec 4, 2023
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Separate signup and signin apis.
Additional Changes
Motivation and Context
How did you test it?
Postman.
If the request is correct, you will get the following response
If the request is correct, you will get the following response
If the request is correct, you will get the following response
If the request is correct, you will get the following response
Checklist
cargo +nightly fmt --all
cargo clippy