Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cybersource mandates and fiserv exp year #2920

Merged
merged 12 commits into from
Nov 21, 2023
Merged

fix: cybersource mandates and fiserv exp year #2920

merged 12 commits into from
Nov 21, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Nov 20, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • [Fiserv] card exp year should be 4 digit
  • [Cybersource] Change connector amount to Base
  • [Cybersource] Implement Mandates

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • [Fiserv] Pass 2 digit card expiry year, still it should work as connector expects 4 digit always
  • [Cybersource] Test Mandates Payments
  • [Cybersource] Test all the flows for Sanity

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 20, 2023
@SamraatBansal SamraatBansal self-assigned this Nov 20, 2023
@SamraatBansal SamraatBansal requested a review from a team as a code owner November 20, 2023 05:33
@SamraatBansal SamraatBansal requested a review from a team as a code owner November 20, 2023 12:07
@SamraatBansal SamraatBansal changed the title fix: fiserv mca metadata and cybersource mandates fix: cybersource mandates and fixers exp year Nov 20, 2023
@SamraatBansal SamraatBansal changed the title fix: cybersource mandates and fixers exp year fix: cybersource mandates and fiserv exp year Nov 20, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Nov 20, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik requested changes Nov 20, 2023
View reviewed changes
crates/router/src/connector/cybersource.rs Outdated Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Show resolved Hide resolved
crates/router/src/connector/cybersource/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
Narayanbhat166
Narayanbhat166 previously approved these changes Nov 20, 2023
View reviewed changes
@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 21, 2023
@lsampras lsampras removed this pull request from the merge queue due to a manual request Nov 21, 2023
@lsampras lsampras merged commit 7f74ae9 into main Nov 21, 2023
10 of 12 checks passed
@lsampras lsampras deleted the refactor/fiserv-cybersource branch November 21, 2023 19:05
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 21, 2023
Gnanasundari24
Gnanasundari24 reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Gnanasundari24 Gnanasundari24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnanasundari24 Gnanasundari24 Gnanasundari24 left review comments

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamraatBansal @ArjunKarthik @Narayanbhat166 @Gnanasundari24 @lsampras @SanchithHegde