feat(router): add unified_code, unified_message in payments response #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
sai-harsha-vardhan
changed the title
sai-harsha-vardhan
changed the title
sai-harsha-vardhan
added
M-database-changes
Narayanbhat166
approved these changes
Nov 20, 2023
SanchithHegde
approved these changes
Nov 20, 2023
Gnanasundari24
deleted the
add-unified-error-code-error-message-in-payments-response
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add unified_code, unified_message in gsm, payment_attempt and payments_response
Currently we send error_code, error_message as connector's error code, message and this varies across connectors. To unify these errors, unified_code and unified_message are introduced which rely on GSM to retrieve the values based on connector, populate them in payment_attempt and send the same in payments response.
Additional Changes
Motivation and Context
How did you test it?
Tested Manually
Create a failed payment with some connector to see unified_code, unified_message being null
Now update the relevant GSM by sending unified_code, unified_message with some valid values
Now re-create the same failed payment to see unified_code, unified_message being set to value based on GSM
Can verify the same unified_code, unified_message in payment_attempt record
Checklist
cargo +nightly fmt --allcargo clippy