Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): add choice to use the appropriate key for jws verification #2917

Merged
merged 6 commits into from
Nov 17, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Can be tested on sandbox by seeing we the Payment method create request to basilisk is returning 200 response.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 17, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner November 17, 2023 14:50
@ShankarSinghC ShankarSinghC self-assigned this Nov 17, 2023
NishantJoshi00
NishantJoshi00 previously approved these changes Nov 17, 2023
NishantJoshi00
NishantJoshi00 previously approved these changes Nov 17, 2023
@SanchithHegde SanchithHegde merged commit 606daa9 into main Nov 17, 2023
9 of 11 checks passed
@SanchithHegde SanchithHegde deleted the fix-rust-locker-mg-2 branch November 17, 2023 15:49
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants