Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Payeezy] update error message #2882

Closed
wants to merge 0 commits into from
Closed

refactor(connector): [Payeezy] update error message #2882

wants to merge 0 commits into from

Conversation

HeetVekariya
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@HeetVekariya HeetVekariya requested a review from a team as a code owner November 16, 2023 05:28
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 16, 2023
swangi-kumari
swangi-kumari approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HeetVekariya
Copy link
Contributor Author

@swangi-kumari Is there anything i need to do ?

@SanchithHegde
Copy link
Member

@HeetVekariya Could you resolve the merge conflicts?

@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Nov 19, 2023
viniAOliver

This comment was marked as resolved.

Sign in to view

@HeetVekariya
Copy link
Contributor Author

@SanchithHegde SanchithHegde removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniAOliver viniAOliver viniAOliver left review comments

@swangi-kumari swangi-kumari swangi-kumari approved these changes

Assignees

@HeetVekariya HeetVekariya

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeetVekariya @SanchithHegde @swangi-kumari @viniAOliver