Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): [Paypal] Change error message from NotSupported to NotImplemented #2877

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

parisosuch-dev
Copy link
Contributor

@parisosuch-dev parisosuch-dev commented Nov 15, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Refactored NotSupported Error calls to NotImplemented in the Paypal transformer.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Changes are here: crates/router/src/connector/paypal/transformer.rs

Motivation and Context

These changes fix the open issue #2858.

How did you test it?

Make any payment for Paypal connector for any PM which is not implemented, and see for the error message - it should be payment method not implemented

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@parisosuch-dev parisosuch-dev requested a review from a team as a code owner November 15, 2023 16:31
@parisosuch-dev
Copy link
Contributor Author

@swangi-kumari are you able to review my PR. I resolved the conflict.

@parisosuch-dev
Copy link
Contributor Author

@swangi-kumari this PR should be ready to go

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Nov 20, 2023
@parisosuch-dev
Copy link
Contributor Author

@prasunna09 possibly review so I can close this out?

@VedantKhairnar
Copy link
Contributor

Hey @parisosuch-dev,
Thanks for the PR and apologies for the delay. We would be happy to review it and get the PR merged.

@parisosuch-dev parisosuch-dev restored the main branch November 30, 2023 03:25
@parisosuch-dev
Copy link
Contributor Author

Hey @parisosuch-dev, Thanks for the PR and apologies for the delay. We would be happy to review it and get the PR merged.

Sounds good -- I reopened the PR.

@swangi-kumari
Copy link
Contributor

Hey @parisosuch-dev ,
Please resolve the conflicts from your branch.

@VedantKhairnar
Copy link
Contributor

Hey @parisosuch-dev ,
Let us know if you are facing any issues and need assistance in the merge conflicts. Happy to help : )

@swangi-kumari swangi-kumari linked an issue Jan 31, 2024 that may be closed by this pull request
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 31, 2024
Merged via the queue into juspay:main with commit 7251f64 Jan 31, 2024
15 checks passed
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [Paypal] Error Message For Connector Implementation
8 participants