refactor(connector): [Square] change error message from NotSupported to NotImplemented

[nain-F49FF806]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

Consistent error messages for not implemented payment method.

Motivation and Context

Resolves #2861

How did you test it?

payment connector create

{
    "connector_type": "fiz_operations",
    "connector_name": "volt",
    "connector_account_details": {
        "auth_type": "MultiAuthKey",
        "api_key": "{{connector_api_key}}",
        "api_secret": "{{connector_api_secret}}",
        "key1": "{{connector_key1}}",
        "key2": "{{connector_key2}}"
    },
    "test_mode": false,
    "disabled": false,
    "payment_methods_enabled": [
                {
            "payment_method": "bank_redirect",
            "payment_method_types": [
                 {
                    "payment_method_type": "open_banking_uk",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": false,
                    "installment_payment_enabled": false
                    // "accepted_currencies": {
                    //     "type": "enable_only",
                    //     "list": [
                    //         "EUR"
                    //     ]
                    // },
                    // "accepted_countries": {
                    //     "type": "enable_only",
                    //     "list": [
                    //         "DE"
                    //     ]
                    // }
                }
            ]
        }
    ],
    "metadata": {
        "city": "NY",
        "unit": "245"
    },
    "connector_webhook_details": {
        "merchant_secret": "dce1d767-7c28-429c-b0fe-9e0b9e91f962"
    },
    "business_country": "US",
    "business_label": "food"
}

create a payment which is not implemented
Payment create

{
    "amount": 6540,
    "currency": "BRL",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "StripeCustomer",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://duck.com",
     "payment_method": "bank_transfer",
    "payment_method_type": "pix",
    "payment_method_data": {
        "bank_transfer": {
            "pix": {}
        }
    },
    "routing": {
        "type": "single",
        "data": "adyen"
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "BR",
            "first_name": "PiX"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "BR",
            "first_name": "PiX"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    }
}

Make any payment for Square for any PM which is not implemented, and see for the error message - it should be payment method not implemented

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

[swangi-kumari]

Hey @nain-F49FF806 , Thanks for PR.
But we'd prefer that contributors comment on an issue before opening a PR for it, so that other contributors are aware that you are working on it. This would also help reduce duplicate effort towards solving the same issue. Please ensure you follow it moving forward.

[nain-F49FF806]

@swangi-kumari Noted.

Saw no one seemed assigned, so just went ahead to have a look at the code before making a comment.
I didn't know if I was going to take it, until I had already finished. Sorry. 😅

On a more fortunate note, I only laid eyes on this today, So hopefully not much time wasted. 🤞
Will make sure to add a comment next time.

Regards.

[swangi-kumari]

Hey @nain-F49FF806 ,
It's fine if you missed. But can you go to respective issue for which you raised this PR and comment on that issue, so that I can assign it to you.

[swangi-kumari]

Hey @nain-F49FF806 ,
Please resolve the conflicts from your branch.

[nain-F49FF806]

@swangi-kumari Have rebased onto the most recent main.
Please have a look and let me know if there's anything else needed.

[SamraatBansal]

We can club all the match arms and propagate the expected common error.
Please use | and throw the NotImplemented error in the end. No need for it to be done twice

[nain-F49FF806]

I had assumed the two blocks were kept separate on purpose to have the AchBank arm generate a report, and the others not.

On second look, it seems the conversion happens automatically for the others anyway, to keep the return type identical.

I shall club them all and also remove the .into_report altogether. Let me know if that is not as intended.