Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routing): Routing prometheus metrics #2870

Merged
merged 9 commits into from
Nov 22, 2023
Merged

feat(routing): Routing prometheus metrics #2870

merged 9 commits into from
Nov 22, 2023

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Nov 14, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adding Prometheus metrics for Routing in OSS

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  1. Hit all the routing APIs
  2. Check grafana for the metric labels
image image image image image image image image image image image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sarthak1799 Sarthak1799 self-assigned this Nov 14, 2023
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner November 14, 2023 09:45
@Sarthak1799 Sarthak1799 added C-feature Category: Feature request or enhancement A-routing Area: Routing labels Nov 16, 2023
vspecky
vspecky previously approved these changes Nov 20, 2023
View reviewed changes
prajjwalkumar17
prajjwalkumar17 reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this LGTM!

crates/router/src/core/metrics.rs Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 4e15d77 Nov 22, 2023
12 of 14 checks passed
@Gnanasundari24 Gnanasundari24 deleted the routing-metrics branch November 22, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@prajjwalkumar17 prajjwalkumar17 prajjwalkumar17 approved these changes

@vspecky vspecky vspecky approved these changes

@lsampras lsampras Awaiting requested review from lsampras

Assignees

@Sarthak1799 Sarthak1799

Labels
A-routing Area: Routing C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sarthak1799 @vspecky @prajjwalkumar17 @Gnanasundari24