Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): [Nuvei] update error message #2867

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

HeetVekariya
Copy link
Contributor

@HeetVekariya HeetVekariya commented Nov 13, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Test Cases

Check for BankRedirect which is not implemented, here we can check for Przelewy24 and we should get notImplemented error message.

  "payment_method": "bank_redirect",
  "payment_method_type": "przelewy_24",
  "payment_method_data": {
    "bank_redirect": {
      "eps": {
          "billing_details": {
              "email": "[email protected]"
          }
      }
    }
  }, 

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@HeetVekariya HeetVekariya requested a review from a team as a code owner November 13, 2023 08:52
@swangi-kumari swangi-kumari linked an issue Nov 15, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 15, 2023
@HeetVekariya
Copy link
Contributor Author

@swangi-kumari is there anything required from my side ?

Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @HeetVekariya!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 26, 2023
Merged via the queue into juspay:main with commit 04b7c03 Nov 26, 2023
12 checks passed
@HeetVekariya
Copy link
Contributor Author

Thank you for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [Nuvei] Error Message For Connector Implementation
3 participants