Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Multisafe Pay] change error message from not supported to not implemented #2851

Merged
merged 3 commits into from
Nov 30, 2023
Merged

refactor(connector): [Multisafe Pay] change error message from not supported to not implemented #2851

merged 3 commits into from
Nov 30, 2023

Conversation

oscar2d2
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

resolve #2842

@oscar2d2 oscar2d2 requested a review from a team as a code owner November 11, 2023 20:15
@swangi-kumari swangi-kumari changed the title refactor: change not supported to not implemented for Multisafe pay refactor(connector): [Multisafe Pay] change error message from not supported to not implemented Nov 13, 2023
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 15, 2023
@swangi-kumari swangi-kumari self-requested a review November 15, 2023 14:05
swangi-kumari
swangi-kumari previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swangi-kumari
Copy link
Contributor

Hey @oscar2d2 ,
Could you please resolve conflicts from your branch.

swangi-kumari
swangi-kumari approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

SanchithHegde
SanchithHegde approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @oscar2d2!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 30, 2023
Merged via the queue into juspay:main with commit 668b943 Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@oscar2d2 oscar2d2

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [Multisafepay] Error Message For Connector Implementation
3 participants
@oscar2d2 @swangi-kumari @SanchithHegde