Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Noon] change error message from not supported to not implemented #2849

Merged
merged 4 commits into from
Feb 2, 2024
Merged

refactor(connector): [Noon] change error message from not supported to not implemented #2849

merged 4 commits into from
Feb 2, 2024

Conversation

oscar2d2
Copy link
Contributor

@oscar2d2 oscar2d2 commented Nov 11, 2023 •
edited by swangi-kumari
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Make any payment for Noon connector for any PM which is not implemented, and see for the error message - it should be payment method not implemented

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Resolve #2844

@oscar2d2 oscar2d2 requested a review from a team as a code owner November 11, 2023 20:02
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 11, 2023
@oscar2d2 oscar2d2 changed the title refactor : change not supported to not implemented for Noon refactor: change not supported to not implemented for Noon Nov 11, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 11, 2023
@swangi-kumari swangi-kumari changed the title refactor: change not supported to not implemented for Noon refactor(connector): [Noon] change error message from not supported to not implemented Nov 13, 2023
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 15, 2023
swangi-kumari
swangi-kumari previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sakilmostak
Sakilmostak previously approved these changes Nov 16, 2023
View reviewed changes
@swangi-kumari
Copy link
Contributor

Hello @oscar2d2 ,
Please resolve the conflicts from your branch.

@swangi-kumari swangi-kumari dismissed stale reviews from Sakilmostak and themself via 60223f7 February 1, 2024 14:23
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 2, 2024
Merged via the queue into juspay:main with commit 892b04f Feb 2, 2024
12 checks passed
sagarnaikjuspay pushed a commit that referenced this pull request Feb 2, 2024
@oscar2d2 @swangi-kumari @sagarnaikjuspay
refactor(connector): [Noon] change error message from not supported t…
b95ef2d 
…o not implemented (#2849)

Co-authored-by: swangi-kumari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@swangi-kumari swangi-kumari swangi-kumari left review comments

@Sakilmostak Sakilmostak Sakilmostak left review comments

Assignees

@oscar2d2 oscar2d2

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [Noon] Error Message For Connector Implementation
6 participants
@oscar2d2 @swangi-kumari @ArjunKarthik @Sakilmostak @srujanchikke @likhinbopanna