Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): [Cryptopay] change error message from not supported to not implemented #2846

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

oscar2d2
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Resolve #2839

@oscar2d2 oscar2d2 requested a review from a team as a code owner November 11, 2023 19:51
@SanchithHegde
Copy link
Member

Hey @oscar2d2, we'd prefer that contributors comment on an issue before opening a PR for it, so that other contributors are aware that you are working on it. This would also help reduce duplicate effort towards solving the same issue. Please ensure you follow it moving forward.

@swangi-kumari swangi-kumari changed the title refactor: change not supported to not implemented for Cryptopay refactor(connector): [Cryptopay] change error message from not supported to not implemented Nov 13, 2023
@oscar2d2
Copy link
Contributor Author

@SanchithHegde thanks for the advice. Can you assign it to me?

swangi-kumari
swangi-kumari previously approved these changes Nov 15, 2023
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers labels Nov 15, 2023
Sakilmostak
Sakilmostak previously approved these changes Nov 16, 2023
@swangi-kumari
Copy link
Contributor

Hey @oscar2d2 ,
Please resolve merge conflicts from your branch.

@oscar2d2 oscar2d2 dismissed stale reviews from Sakilmostak and swangi-kumari via f8c0a46 November 30, 2023 19:59
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @oscar2d2!

@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 17, 2023
Merged via the queue into juspay:main with commit 2d895be Dec 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [CryptoPay] Error Message For Connector Implementation
4 participants