Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): [ACI] change payment error message from not supported to not implemented error #2837

Merged
merged 4 commits into from
Dec 17, 2023
Merged

refactor(router): [ACI] change payment error message from not supported to not implemented error #2837

merged 4 commits into from
Dec 17, 2023

Conversation

oscar2d2
Copy link
Contributor

@oscar2d2 oscar2d2 commented Nov 11, 2023 •
edited by swangi-kumari
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual checking

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Fixes 2836

@oscar2d2 oscar2d2 requested a review from a team as a code owner November 11, 2023 07:35
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 11, 2023
@oscar2d2 oscar2d2 changed the title refractor: change payment error message from not supported to not imp… refractor(connector): change payment error message from not supported to not imp… Nov 11, 2023
@oscar2d2 oscar2d2 changed the title refractor(connector): change payment error message from not supported to not imp… refractor(router): change payment error message from not supported to not imp… Nov 11, 2023
@oscar2d2 oscar2d2 changed the title refractor(router): change payment error message from not supported to not imp… refactor(router): change payment error message from not supported to not imp… Nov 11, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Nov 11, 2023
@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Nov 11, 2023
@swangi-kumari
Copy link
Contributor

Hey @oscar2d2 ,
The issue which you picked was for ACI connector.
Can you please make the required changes in that connector.

@oscar2d2
Copy link
Contributor Author

Hey @oscar2d2 , The issue which you picked was for ACI connector. Can you please make the required changes in that connector.

Hi @swangi-kumari, thanks for the review. I have updated the branch, would you please review again?

@swangi-kumari
Copy link
Contributor

Hey @oscar2d2 ,
Please resolve the conflicts from your branch.

swangi-kumari
swangi-kumari approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swangi-kumari swangi-kumari changed the title refactor(router): change payment error message from not supported to not imp… refactor(router): [ACI] change payment error message from not supported to not imp… Dec 17, 2023
@swangi-kumari swangi-kumari changed the title refactor(router): [ACI] change payment error message from not supported to not imp… refactor(router): [ACI] change payment error message from not supported to not implemented error Dec 17, 2023
SanchithHegde
SanchithHegde approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @oscar2d2!

@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 17, 2023
Merged via the queue into juspay:main with commit cc12e8a Dec 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

Assignees

@oscar2d2 oscar2d2

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] : [ACI] Error Message For Connector Implementation
3 participants
@oscar2d2 @swangi-kumari @SanchithHegde