feat(router): profile specific fallback derivation while routing payments #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajjwalkumar17
added
C-feature
…ub.com/juspay/hyperswitch into feat/profile_specific_fallback_routing
vspecky
previously approved these changes
Nov 8, 2023
Narayanbhat166
previously approved these changes
Nov 8, 2023
prajjwalkumar17
dismissed stale reviews from Narayanbhat166 and vspecky
via
83acfcf
…ub.com/juspay/hyperswitch into feat/profile_specific_fallback_routing
…ub.com/juspay/hyperswitch into feat/profile_specific_fallback_routing
| let mca = state | ||
| .store | ||
| .insert_merchant_connector_account(merchant_connector_account, &key_store) | ||
| .await | ||
| .to_duplicate_response( | ||
| errors::ApiErrorResponse::DuplicateMerchantConnectorAccount { | ||
| profile_id, | ||
| profile_id: profile_id.clone(), | ||
| connector_name: req.connector_name.to_string(), |
There was a problem hiding this comment.
we have to use merchant_connector_id here. There can be many connectors with the same name
cc: @vspecky
There was a problem hiding this comment.
We will make this change in next PR as we have discussed.
2 tasks
Narayanbhat166
previously approved these changes
Nov 10, 2023
lsampras
previously approved these changes
Nov 11, 2023
Narayanbhat166
previously approved these changes
Nov 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
prajjwalkumar17
dismissed stale reviews from Narayanbhat166 and lsampras
via
bcf1a57
lsampras
approved these changes
Nov 13, 2023
Narayanbhat166
approved these changes
Nov 13, 2023
prajjwalkumar17
added
A-routing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
default-fallbacksare defined specific to profile i.e every profile will correspond to different fallbacks and while deriving the fallbacks we are doing that based on profile.Additional Changes
Motivation and Context
How did you test it?
The tests will be same as this PR:
https://github.com/juspay/hyperswitch-cloud/pull/2949
Checklist
cargo +nightly fmt --allcargo clippy