refactor(connector): remove default cases for Authorizedotnet, Braintree and Fiserv Connector #2796
Conversation
swangi-kumari
added
A-connector-integration
swangi-kumari
requested review from
ArjunKarthik,
Sakilmostak and
srujanchikke
Co-authored-by: chikke srujan <[email protected]>
…into default-case
| | api::PaymentMethodData::GiftCard(_) | ||
| | api::PaymentMethodData::CardToken(_) => { | ||
| Err(errors::ConnectorError::NotImplemented( | ||
| utils::get_unimplemented_payment_method_error_message("braintree"), |
There was a problem hiding this comment.
This is supposed to be fiserv .
| | enums::CaptureMethod::ManualMultiple | ||
| | enums::CaptureMethod::Scheduled => Self::Final, |
There was a problem hiding this comment.
ManualMultiple and Scheduled is not supported by the connector. In such cases throw error
| | SyncStatus::Voided | ||
| | SyncStatus::CouldNotVoid | ||
| | SyncStatus::GeneralError | ||
| | SyncStatus::FDSPendingReview => Self::Failure, |
There was a problem hiding this comment.
Why FDSPendingReview, SettledSuccessfully, AuthorizedPendingCapture, CapturedPendingSettlement, Voided should be mapped to Failure?
There was a problem hiding this comment.
@deepanshu-iiitu will handle the status mapping modifications in the pull request where he is addressing the connector audit fixes.
| .map(|c| AuthorizationIndicator { | ||
| authorization_indicator: c.into(), | ||
| }); | ||
| let authorization_indicator_type = match item.router_data.request.capture_method { |
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
I refactored the CaptureMethod from from to try_from , in order to throw the error for ManualMultiple and Scheduled. this was a relative change for that
Type of Change
Description
Resolves 4376
Issue: defaults case in match shouldn't be handled using "_"
Solution: "_" will never let the developer know impact of his changes incase of new addition of enum variants. By having the all cases in match compiler itself will throw errors wherever new enums needs to be handled.
(In this PR it is done for Authorizrdotnet, Braintree and Fiserv Connector)
Additional Changes
Motivation and Context
How did you test it?
Do payment create for Authorizedotnet, Braintree and Fiserv Connector for any payment method which is not implemented it should throw the error
here is payment request for PIX PM
{ "amount": 6540, "currency": "BRL", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer", "email": "[email protected]", "name": "John Doe", "phone": "999999999", "phone_country_code": "+1", "description": "Its my first payment request", "authentication_type": "no_three_ds", "return_url": "https://duck.com", "payment_method": "bank_transfer", "payment_method_type": "pix", "payment_method_data": { "bank_transfer": { "pix": {} } }, "billing": { "address": { "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "California", "zip": "94122", "country": "BR", "first_name": "PiX" } }, "shipping": { "address": { "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "city": "San Fransico", "state": "California", "zip": "94122", "country": "BR", "first_name": "PiX" } }, "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "metadata": { "udf1": "value1", "new_customer": "true", "login_date": "2019-09-10T10:11:12Z" } }Checklist
cargo +nightly fmt --allcargo clippy