Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): add extracted fields based on req/res types #2795

Merged
merged 15 commits into from
Nov 8, 2023

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Nov 6, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add a trait to allow adding top level fields & types for each request
  • these fields are now collected from either the response or request in order
  • This are exposed as top level fields allowing to query over multiple types of api events with a single tag

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This will allow us to query multiple events with a single filter allowing some type of tag based searches
for e.g you can filter all the payment related api calls with a single payment id filter

How did you test it?

  • Make a payment create api call & check logs
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added A-dependencies Area: Dependencies C-feature Category: Feature request or enhancement labels Nov 6, 2023
@lsampras lsampras self-assigned this Nov 6, 2023
@lsampras lsampras requested review from a team as code owners November 6, 2023 14:53
ivor11
ivor11 previously approved these changes Nov 7, 2023
@lsampras lsampras dismissed stale reviews from harsh-sharma-juspay and ivor11 via f6962cd November 8, 2023 10:25
Copy link
Member

@NishantJoshi00 NishantJoshi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good!

Makefile Outdated Show resolved Hide resolved
crates/common_utils/src/lib.rs Show resolved Hide resolved
@lsampras
Copy link
Member Author

lsampras commented Nov 8, 2023

force-merging as conditions met

@lsampras lsampras merged commit 8985794 into main Nov 8, 2023
10 of 12 checks passed
@lsampras lsampras deleted the add_payment_id branch November 8, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependencies C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants