refactor: #3059 group db update calls

[akshay-97]

…ment_intent

Type of Change

• Bugfix
• New feature
• Enhancement
• [ x] Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

group connector_response, payment_attempt db update calls with payment_intent

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

make db calls concurrent to improve api latency

How did you test it?

compare values of updated objects with db update returned object if they match
print connector_response in payment intent and connector_response returned from awaiting db update and compare
in payment confirm api
curl --location --request POST 'http://localhost:8080/payments/pay_xNnINZf39jNKoFPoHJ0B/confirm' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: ***' \ --data-raw ' {}'

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible
• I added a CHANGELOG entry if applicable

[dracarys18]

Suggested change

	let payment_attempt = match payment_attempt_update {
	Some(payment_attempt_update) => PaymentAttempt::from_storage_model(
	payment_attempt_update
	.to_storage_model()
	.apply_changeset(payment_attempt.clone().to_storage_model()),
	),
	None => payment_attempt,
	};
	let payment_attempt = payment_attempt_update.map(|payment_attempt_update|{
	PaymentAttempt::from_storage_model(
	payment_attempt_update
	.to_storage_model()
	.apply_changeset(payment_attempt.clone().to_storage_model()),
	)
	});

[akshay-97]

map would apply function inside Option and return Option back right, want a default value here as well, in case of None

[dracarys18]

You can use unwrap_or_else(|f|)

[dracarys18]

Suggested change

	let connector_response = match connector_response_update {
	Some(connector_response_update) => {
	connector_response_update.apply_changeset(connector_response.clone())
	}
	None => connector_response,
	};
	let connector_response = connector_response_update.map(|connector_response_update| {
	connector_response_update.apply_changeset(connector_response.clone())
	});