Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [BANKOFAMERICA] Implement Cards for Bank of America #2765

Merged
merged 34 commits into from
Nov 16, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

@deepanshu-iiitu deepanshu-iiitu commented Nov 2, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Bank of America is a payment connector from North America.
Add Card payment support for Bank of America.
https://poshelp.bofamerchantservices.com/?cm_mmc=MS-MerchSvcs-_-vanity-_-MZ01VN000D_merchanthelp-_-NA#card

Supported Flows:

  • Authorize
  • Capture
  • PSync
  • Void
  • Refund
  • RSync

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add Card Payments for Payments and Refunds flow for new connector Bank of America.

How did you test it?

Postman collection is added.
Basic flows like Authorize, Capture, Void, PSYNC, Refunds and RSYNC require testing for Cards Non-3DS.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners November 2, 2023 11:55
@deepanshu-iiitu deepanshu-iiitu changed the title feat(connector): [BANKOFAMERICA] Activate Bank of America feat(connector): [BANKOFAMERICA] Implement Cards for Bank of America Nov 2, 2023
@deepanshu-iiitu deepanshu-iiitu self-assigned this Nov 3, 2023
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Nov 3, 2023
Base automatically changed from boa_template to main November 6, 2023 08:52
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner November 6, 2023 08:52
crates/router/src/connector/bankofamerica.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica/transformers.rs Outdated Show resolved Hide resolved
BankofamericaPaymentStatus::Succeeded => Self::Charged,
BankofamericaPaymentStatus::Failed => Self::Failure,
BankofamericaPaymentStatus::Authorized
| BankofamericaPaymentStatus::AuthorizedPendingReview => Self::Authorized,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the definition of AuthorizedPendingReview, why is this mapped to Authorized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be addressed in separate issue https://github.com/juspay/hyperswitch-cloud/issues/3226

crates/router/src/connector/bankofamerica/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/bankofamerica/transformers.rs Outdated Show resolved Hide resolved
@swangi-kumari swangi-kumari requested a review from a team as a code owner November 10, 2023 11:06
@deepanshu-iiitu
Copy link
Contributor Author

@preetamrevankar preetamrevankar added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit e8de3a7 Nov 16, 2023
10 of 12 checks passed
@preetamrevankar preetamrevankar deleted the boa_card branch November 16, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

8 participants