Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apievent): added hs latency to api event #2734

Merged
merged 9 commits into from
Nov 13, 2023
Merged

feat(apievent): added hs latency to api event #2734

merged 9 commits into from
Nov 13, 2023

Conversation

harsh-sharma-juspay
Copy link
Contributor

@harsh-sharma-juspay harsh-sharma-juspay commented Oct 30, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

added HS latency to the api log event only if header x-hs-latency is true

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

do a payment confirm api call with the x-latency header

Check logs for this field

Screenshot 2023-10-31 at 7 13 37 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@harsh-sharma-juspay harsh-sharma-juspay requested a review from a team as a code owner October 30, 2023 14:05
lsampras
lsampras previously approved these changes Oct 30, 2023
@lsampras
Copy link
Member

Can you also add description / testing scenarios for this?

@harsh-sharma-juspay
Copy link
Contributor Author

Screenshot 2023-10-31 at 7 13 37 PM

lsampras
lsampras previously approved these changes Nov 2, 2023
@lsampras lsampras added this pull request to the merge queue Nov 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 12, 2023
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit c124511 Nov 13, 2023
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the api_event branch November 13, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants