feat(connector): [Elavon] Add card payments, psync, refunds, rsync and void flows #2728

AkshayaFoiger · 2023-10-30T07:07:07Z

Type of Change

Description

Elavon Inc., formerly NOVA, is a processor of card transactions and a subsidiary of U.S. Bancorp. Elavon offers merchant processing in more than 30 countries and supports the payment needs of more than 1,000,000 merchant locations across the globe.

Resolves #2957

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

How did you test it?

Can't be tested as Elavon has a closed sandbox.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

SamraatBansal · 2023-11-29T13:16:15Z

crates/router/src/core/payments/flows.rs

@@ -142,6 +142,7 @@ impl<const T: u8>
 }

 default_imp_for_complete_authorize!(
+    connector::Elavon,


Put all the default_imps in Alphabetical Order

SamraatBansal · 2023-11-29T13:16:44Z

crates/router/src/types/api.rs

@@ -389,6 +389,7 @@ impl ConnectorData {
                enums::Connector::Tsys => Ok(Box::new(&connector::Tsys)),
                enums::Connector::Volt => Ok(Box::new(&connector::Volt)),
                enums::Connector::Zen => Ok(Box::new(&connector::Zen)),
+                enums::Connector::Elavon => Ok(Box::new(&connector::Elavon)),


Put in alphabetical order

SamraatBansal · 2023-11-29T13:17:35Z

crates/router/tests/connectors/sample_auth.toml

+api_key="API Key"
+key1 = "transaction key"


If its a HeaderKey there should not be 2 keys

SamraatBansal · 2023-11-29T13:20:50Z

crates/router/src/connector/elavon.rs

+                headers::CONTENT_TYPE.to_string(),
+                self.get_content_type().to_string().into(),
+            ),
+            (headers::ACCEPT_VERSION.to_string(), "1".to_string().into()),


Declare this "1.to_string().into()" as a constant on top

SamraatBansal · 2023-11-29T13:23:17Z

crates/router/src/connector/elavon.rs

+            (headers::ACCEPT_VERSION.to_string(), "1".to_string().into()),
+            (
+                headers::ACCEPT.to_string(),
+                "application/json;charset=UTF-8".to_string().into(),


Suggested change

"application/json;charset=UTF-8".to_string().into(),

self.get_content_type().to_string().into(),

SamraatBansal · 2023-11-29T13:45:51Z

crates/router/src/connector/elavon/transformers.rs

+#[serde(rename_all = "camelCase")]
+pub struct ElavonCardData {
+    holder_name: Secret<String>,
+    number: Secret<String>,


Suggested change

number: Secret<String>,

number: cards::CardNumber,

SamraatBansal · 2023-11-30T08:02:37Z

crates/router/src/connector/elavon.rs

+        Ok(format!(
+            "{}/{}/{}",
+            self.base_url(connectors),
+            "transactions",
+            req.request.connector_transaction_id
+        ))


Suggested change

Ok(format!(

"{}/{}/{}",

self.base_url(connectors),

"transactions",

req.request.connector_transaction_id

))

Ok(format!(

"{}/transactions/{}",

self.base_url(connectors),

req.request.connector_transaction_id

))

SamraatBansal · 2023-11-30T08:11:04Z

crates/router/src/connector/elavon/transformers.rs

+}
+
+pub struct ElavonAuthType {
+    pub(super) api_key: Secret<String>,


if its a BodyKey 2 key fields should be present in this struct

SamraatBansal · 2023-11-30T08:11:24Z

crates/router/src/connector/elavon/transformers.rs

+    #[default]
+    Unknown,


Why have we set default value to unknown?

SamraatBansal · 2023-11-30T08:14:00Z

crates/router/src/connector/elavon/transformers.rs

+            ElavonStatus::Declined => Self::Failure,
+            ElavonStatus::Authorized => Self::Pending,
+            ElavonStatus::Captured => Self::Pending,
+            ElavonStatus::Voided => Self::Failure,
+            ElavonStatus::Settled => Self::Success,
+            ElavonStatus::Expired => Self::Failure,
+            ElavonStatus::SettlementDelayed => Self::Pending,
+            ElavonStatus::Rejected => Self::Failure,
+            ElavonStatus::HeldForReview => Self::ManualReview,
+            ElavonStatus::Unknown => Self::Pending, // Have to get confirmation from the connector
+            ElavonStatus::AuthorizationPending => Self::Pending,
+        }


Suggested change

ElavonStatus::Declined => Self::Failure,

ElavonStatus::Authorized => Self::Pending,

ElavonStatus::Captured => Self::Pending,

ElavonStatus::Voided => Self::Failure,

ElavonStatus::Settled => Self::Success,

ElavonStatus::Expired => Self::Failure,

ElavonStatus::SettlementDelayed => Self::Pending,

ElavonStatus::Rejected => Self::Failure,

ElavonStatus::HeldForReview => Self::ManualReview,

ElavonStatus::Unknown => Self::Pending, // Have to get confirmation from the connector

ElavonStatus::AuthorizationPending => Self::Pending,

}

ElavonStatus::Declined | ElavonStatus::Voided | ElavonStatus::Expired | ElavonStatus::Rejected => Self::Failure,

ElavonStatus::Settled => Self::Success,

ElavonStatus::HeldForReview => Self::ManualReview,

ElavonStatus::Unknown => Self::Pending, // Have to get confirmation from the connector

ElavonStatus::AuthorizationPending | ElavonStatus::SettlementDelayed | ElavonStatus::Captured | ElavonStatus::Authorized => Self::Pending,

}

AkshayaFoiger · 2023-11-30T09:27:21Z

Blocking this Pull Request as Elavon converge, no more supports REST API integration.

JacobHayes · 2024-01-09T14:19:00Z

Blocking this Pull Request as Elavon converge, no more supports REST API integration.

I'm not sure what the API was before, but it seems they have an XML (😢) API in case that'd be possible to use: https://developer.elavon.com/products/converge/v1/xmlapi

edit: ah, but perhaps it's pretty limited to only transactions, but not management?

AkshayaFoiger · 2024-05-30T06:56:57Z

Connector contract changed

AkshayaFoiger added 10 commits October 27, 2023 11:36

add payments and psync flow for Elavon

93d59fe

add Elavon to api.rs and admin.rs

d7d09e1

add capture, void, refund and rsync for elavon

a3b10aa

add Connectors as a parameter for get_request_body

0031c6c

fix formatting error

f6ae85a

fix clippy error

4893b27

Merge branch 'update/request_body' into connector/Elavon

a372571

add parent_transaction

000f95d

remove comments

9178143

update the sample_auth.toml

b3acf14

AkshayaFoiger added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Oct 30, 2023

AkshayaFoiger self-assigned this Oct 30, 2023

AkshayaFoiger requested review from a team as code owners October 30, 2023 07:07

github-actions bot and others added 3 commits October 30, 2023 07:18

docs(openapi): re-generate OpenAPI specification

d380c39

add elavon url

3ce3d6a

refactor elavon transformer

162a233

AkshayaFoiger requested a review from a team as a November 2, 2023 08:13

AkshayaFoiger force-pushed the connector/Elavon branch from 692d3c5 to 162a233 Compare November 2, 2023 09:23

Base automatically changed from update/request_body to main November 8, 2023 10:38

AkshayaFoiger added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 17, 2023

AkshayaFoiger force-pushed the connector/Elavon branch from 9b47f33 to 162a233 Compare November 20, 2023 06:09

AkshayaFoiger and others added 5 commits November 20, 2023 11:45

Merge branch 'main' into connector/Elavon

d1dcaf7

chore: run formatter

52ba327

resolve conflicts

3916ba1

Merge branch 'main' into connector/Elavon

085521b

resolve merge conflict

3152530

AkshayaFoiger and others added 2 commits November 30, 2023 12:27

fix cargo clippy error

287dbc6

Merge branch 'main' into connector/Elavon

ec0a65f

SamraatBansal requested changes Nov 30, 2023

View reviewed changes

AkshayaFoiger added S-blocked Status: Blocked on something else or other implementation work and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 30, 2023

AkshayaFoiger closed this May 30, 2024

SanchithHegde deleted the connector/Elavon branch June 2, 2024 17:57

SanchithHegde removed the S-blocked Status: Blocked on something else or other implementation work label Jun 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [Elavon] Add card payments, psync, refunds, rsync and void flows #2728

feat(connector): [Elavon] Add card payments, psync, refunds, rsync and void flows #2728

AkshayaFoiger commented Oct 30, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 29, 2023

SamraatBansal Nov 30, 2023

SamraatBansal Nov 30, 2023

SamraatBansal Nov 30, 2023

SamraatBansal Nov 30, 2023

AkshayaFoiger commented Nov 30, 2023 •

edited

Loading

JacobHayes commented Jan 9, 2024 •

edited

Loading

AkshayaFoiger commented May 30, 2024

	"application/json;charset=UTF-8".to_string().into(),
	self.get_content_type().to_string().into(),

feat(connector): [Elavon] Add card payments, psync, refunds, rsync and void flows #2728

feat(connector): [Elavon] Add card payments, psync, refunds, rsync and void flows #2728

Conversation

AkshayaFoiger commented Oct 30, 2023

Type of Change

Description

Additional Changes

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshayaFoiger commented Nov 30, 2023 • edited Loading

JacobHayes commented Jan 9, 2024 • edited Loading

AkshayaFoiger commented May 30, 2024

AkshayaFoiger commented Nov 30, 2023 •

edited

Loading

JacobHayes commented Jan 9, 2024 •

edited

Loading