Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connect): [NMI] Use connector_response_reference_id as reference to merchant #2702

Merged
merged 20 commits into from
Feb 6, 2024
Merged

feat(connect): [NMI] Use connector_response_reference_id as reference to merchant #2702

merged 20 commits into from
Feb 6, 2024

Conversation

TejasMate
Copy link
Contributor

@TejasMate TejasMate commented Oct 26, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Make any Payment for connector NMI and see that you are getting "reference_id" field in the payments response of hyperswitch. It should not be null.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@TejasMate
Update transformers.rs
72cc41c
@TejasMate
Merge pull request #1 from TejasMate/TejasMate-patch-2
3daa994 
feat(connect): [NMI] Use connector_response_reference_id as reference to merchant
@TejasMate TejasMate requested a review from a team as a code owner October 26, 2023 17:24
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 26, 2023
@swangi-kumari
Copy link
Contributor

Hey @TejasMate ,
Pls address the CI fails
Run cargo +nightly fmt for formatting.

@AkshayaFoiger AkshayaFoiger requested review from AkshayaFoiger and removed request for AkshayaFoiger October 31, 2023 09:11
@deepanshu-iiitu deepanshu-iiitu self-requested a review October 31, 2023 11:45
deepanshu-iiitu
deepanshu-iiitu requested changes Oct 31, 2023
View reviewed changes
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/nmi/transformers.rs Outdated Show resolved Hide resolved
@deepanshu-iiitu deepanshu-iiitu added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 31, 2023
@deepanshu-iiitu deepanshu-iiitu self-requested a review November 2, 2023 07:42
@deepanshu-iiitu deepanshu-iiitu self-requested a review November 2, 2023 08:10
@swangi-kumari
Copy link
Contributor

Hey @TejasMate ,
Thanks for your interest in contributing to hyperswitch.
Let us know if you need any assistance from our end.
Also, even if hacktoberfest is over, we should celebrate open source everyday and we are open for more contributions from you.
We would still be rewarding folks with goodies even if the PR gets merged post hacktoberfest.
May the Source be with you!

@deepanshu-iiitu
Copy link
Contributor

Hey @TejasMate ,
Are you working on the requested changes?

@TejasMate
Copy link
Contributor Author

@deepanshu-iiitu, I apologize for the delay. I will address all the issues this Sunday once I am free from exams

@swangi-kumari swangi-kumari linked an issue Feb 5, 2024 that may be closed by this pull request
[FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant #2338
Closed
2 tasks
@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 6, 2024
Merged via the queue into juspay:main with commit 683c1b8 Feb 6, 2024
12 checks passed
@pixincreate pixincreate removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

Assignees

@TejasMate TejasMate

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [NMI] Use connector_response_reference_id as reference to merchant
6 participants
@TejasMate @swangi-kumari @deepanshu-iiitu @ArjunKarthik @pixincreate @likhinbopanna