Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): tsys default case handling #2672

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refactor(router): tsys default case handling #2672

merged 2 commits into from
Oct 25, 2023

Conversation

Harshwardhan9431
Copy link
Contributor

@Harshwardhan9431 Harshwardhan9431 commented Oct 23, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves: #2288

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Harshwardhan9431 Harshwardhan9431 requested a review from a team as a code owner October 23, 2023 21:26
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 25, 2023
Sangamesh26
Sangamesh26 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Sangamesh26 Sangamesh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

SanchithHegde
SanchithHegde approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Harshwardhan9431!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 25, 2023
@SanchithHegde SanchithHegde added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 25, 2023
Merged via the queue into juspay:main with commit 9ff2721 Oct 25, 2023
10 checks passed
@swangi-kumari
Copy link
Contributor

Hey @Harshwardhan9431 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Harshwardhan9431 Harshwardhan9431

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [Tsys] Remove Default Case Handling
5 participants
@Harshwardhan9431 @swangi-kumari @SanchithHegde @SamraatBansal @Sangamesh26