Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): Add request body to api events logger #2660

Merged
merged 3 commits into from
Oct 21, 2023
Merged

feat(events): Add request body to api events logger #2660

merged 3 commits into from
Oct 21, 2023

Conversation

lsampras
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add a debug representation of request & response to api event

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Adding the request & response to API events would help provide more info about the type of query

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added A-framework Area: Framework C-feature Category: Feature request or enhancement labels Oct 21, 2023
@lsampras lsampras self-assigned this Oct 21, 2023
@lsampras lsampras requested a review from a team as a code owner October 21, 2023 07:04
@lsampras lsampras added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit 830eee9 Oct 21, 2023
9 of 10 checks passed
@lsampras lsampras deleted the add_req_body branch October 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh-sharma-juspay harsh-sharma-juspay harsh-sharma-juspay approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Assignees

@lsampras lsampras

Labels
A-framework Area: Framework C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsampras @NishantJoshi00 @harsh-sharma-juspay