chore(env): add ttl as env variable #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
SanchithHegde
previously approved these changes
Oct 22, 2023
jarnura
previously approved these changes
Oct 25, 2023
dracarys18
dismissed stale reviews from jarnura and SanchithHegde
via
66abe63
jarnura
approved these changes
Oct 30, 2023
sai-harsha-vardhan
approved these changes
Oct 30, 2023
| [kv_config] | ||
| # TTL for KV in seconds | ||
| ttl = 900 |
There was a problem hiding this comment.
Authentication of client secret is done based on merchant_intent_fullfillment time, so shouldn't data live in KV for merchant_intent_fullfillment time interval.
Will failing to fetch from KV fallback to DB ?
Will the data be found in DB always as soon as it is expired in Redis ?
There was a problem hiding this comment.
We will have a bigger TTL in prod env so this problem won't occur
Abhicodes-crypto
approved these changes
Oct 30, 2023
SanchithHegde
removed
the
S-waiting-on-review
Abhicodes-crypto
pushed a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add TTL for KV as environment variable.
Additional Changes
Motivation and Context
Add TTL for KV as environment variable.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy