Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [CryptoPay] Remove Default Case Handling #2643

Merged
merged 17 commits into from
Oct 25, 2023
Merged

refactor(connector): [CryptoPay] Remove Default Case Handling #2643

merged 17 commits into from
Oct 25, 2023

Conversation

ashutuptiwari
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed the default match case as mentioned in the issue

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ashutuptiwari ashutuptiwari requested a review from a team as a code owner October 19, 2023 10:21
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 19, 2023
@ashutuptiwari ashutuptiwari changed the title fix issue:: [REFACTOR]: [CryptoPay] Remove Default Case Handling #2267 refactor(connector): [CryptoPay] Remove Default Case Handling Oct 19, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 19, 2023
@ashutuptiwari
Copy link
Contributor Author

Please review @swangi-kumari and let me know of any changes that are to be made.

@SanchithHegde
Copy link
Member

Hey @ashutuptiwari, could you address the failing CI checks?

@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 19, 2023
@SanchithHegde SanchithHegde linked an issue Oct 19, 2023 that may be closed by this pull request
[REFACTOR]: [CryptoPay] Remove Default Case Handling #2267
Closed
2 tasks
@ashutuptiwari
Copy link
Contributor Author

On it @SanchithHegde

@ashutuptiwari
Copy link
Contributor Author

@SanchithHegde I'm unable to run this locally, please check if the changes i made are working as expected. If yes, I'll revisit the formatting issues and that should be it.

@SanchithHegde
Copy link
Member

@ashutuptiwari Yeah looks like compilation would be successful, formatting should be the only one remaining.

@ashutuptiwari
Copy link
Contributor Author

Alright then @SanchithHegde

@ashutuptiwari
Copy link
Contributor Author

Please review

@swangi-kumari
Copy link
Contributor

Hello @ashutuptiwari ,
This is not the changes which was required here. You don't need to put if and else condition, instead remove ( _=> ) and fill the matching arms for Payment Methods, So mention and handle each and every variant explicitly for that part.

@ashutuptiwari
Copy link
Contributor Author

ashutuptiwari commented Oct 21, 2023 •
edited
Loading

Alright, I'll look into it @swangi-kumari

@ashutuptiwari
Copy link
Contributor Author

ashutuptiwari commented Oct 21, 2023 •
edited
Loading

Please approve the workflow @SanchithHegde @swangi-kumari

@ashutuptiwari
Copy link
Contributor Author

ashutuptiwari commented Oct 23, 2023 •
edited
Loading

please review @prasunna09 @swangi-kumari @Sangamesh26

SanchithHegde
SanchithHegde approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @ashutuptiwari!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 25, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 25, 2023
Sangamesh26
Sangamesh26 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Sangamesh26 Sangamesh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ashutuptiwari
Copy link
Contributor Author

Happy Happy Happy

Merged via the queue into juspay:main with commit 6428d07 Oct 25, 2023
10 checks passed
@ashutuptiwari
Copy link
Contributor Author

ashutuptiwari commented Oct 25, 2023 •
edited
Loading

Thank you @SanchithHegde @prasunna09 @swangi-kumari for your inputs on this. Learnt a lot throught this PR. Will definitely look forward to making more contributions.
Cheers!

@swangi-kumari
Copy link
Contributor

Hey @ashutuptiwari ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@ashutuptiwari
Copy link
Contributor Author

Hi guys, I see my name isn't on the contributors list, nor have I received the swag.
Is this a mistake or is it amid the delivery process?
Thank you
@SanchithHegde @swangi-kumari @Sangamesh26 @prasunna09

@VedantKhairnar
Copy link
Contributor

Hey @ashutuptiwari
I'll have a word with the vendor around the shipment status.
Will get back to you soon. Thanks for your patience.

@ashutuptiwari
Copy link
Contributor Author

Alright thanks @VedantKhairnar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasunna09 prasunna09 prasunna09 approved these changes

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@ashutuptiwari ashutuptiwari

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [CryptoPay] Remove Default Case Handling
6 participants
@ashutuptiwari @SanchithHegde @swangi-kumari @VedantKhairnar @Sangamesh26 @prasunna09