Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add surcharge_applicable to payment_intent and remove surcharge_metadata from payment_attempt #2642

Merged
merged 6 commits into from
Oct 19, 2023
Merged

refactor: add surcharge_applicable to payment_intent and remove surcharge_metadata from payment_attempt #2642

merged 6 commits into from
Oct 19, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Oct 19, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

changes in this PR:

  1. Add surcharge_applicable field to payment_intent
  2. Remove surcharge_metadata_field from payment_attempt
  3. Add session_surcharge_details to PaymentData

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-database-changes Metadata: This PR involves database schema changes labels Oct 19, 2023
@hrithikesh026 hrithikesh026 added this to the October 2023 Milestone milestone Oct 19, 2023
@hrithikesh026 hrithikesh026 self-assigned this Oct 19, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners October 19, 2023 09:58
jarnura
jarnura previously approved these changes Oct 19, 2023
View reviewed changes
jarnura
jarnura previously approved these changes Oct 19, 2023
View reviewed changes
@hrithikesh026 hrithikesh026 requested a review from jarnura October 19, 2023 13:04
@hrithikesh026 hrithikesh026 changed the title feat: add surcharge_applicable to payment_intent and remove surcharge_metadata from payment_attempt refactor: add surcharge_applicable to payment_intent and remove surcharge_metadata from payment_attempt Oct 19, 2023
@jarnura jarnura added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit e5fbaae Oct 19, 2023
10 of 11 checks passed
@jarnura jarnura deleted the add-surcharge-applicable-column-to-intent branch October 19, 2023 14:05
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels
C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrithikesh026 @jarnura @Narayanbhat166 @SanchithHegde