Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): [Nexi nets] Remove Default Case Handling #2639

Merged
merged 1 commit into from
Oct 20, 2023
Merged

refactor(router): [Nexi nets] Remove Default Case Handling #2639

merged 1 commit into from
Oct 20, 2023

Conversation

Harshwardhan9431
Copy link
Contributor

@Harshwardhan9431 Harshwardhan9431 commented Oct 19, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Harshwardhan9431 Harshwardhan9431 requested a review from a team as a code owner October 19, 2023 03:44
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 19, 2023
@Harshwardhan9431 Harshwardhan9431 changed the title [REFACTOR]: [Nexi nets] Remove Default Case Handling (Fixes #2275) refactor(router): [Nexi nets] Remove Default Case Handling (Fixes #2275) Oct 19, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 19, 2023
@Harshwardhan9431 Harshwardhan9431 mentioned this pull request Oct 19, 2023
Closed
2 tasks
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Oct 19, 2023
@swangi-kumari swangi-kumari added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 19, 2023
@SanchithHegde
Copy link
Member

@Harshwardhan9431 Can you address the failing CI checks?

@SanchithHegde SanchithHegde added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 19, 2023
Sangamesh26
Sangamesh26 previously approved these changes Oct 19, 2023
View reviewed changes
@Sangamesh26
Copy link
Contributor

Sangamesh26 commented Oct 19, 2023 •
edited
Loading

code LGTM :)
Pls address the CI fails

Run cargo +nightly fmt for formatting

@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 19, 2023
SanchithHegde
SanchithHegde approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Harshwardhan9431!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 20, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 20, 2023
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request Oct 20, 2023
@SanchithHegde SanchithHegde changed the title refactor(router): [Nexi nets] Remove Default Case Handling (Fixes #2275) refactor(router): [Nexi nets] Remove Default Case Handling Oct 20, 2023
@SanchithHegde SanchithHegde linked an issue Oct 20, 2023 that may be closed by this pull request
[REFACTOR]: [Nexi nets] Remove Default Case Handling #2275
Closed
2 tasks
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 20, 2023
Merged via the queue into juspay:main with commit 4b64c56 Oct 20, 2023
12 checks passed
@swangi-kumari
Copy link
Contributor

Hello @Harshwardhan9431 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sangamesh26 Sangamesh26 Sangamesh26 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Harshwardhan9431 Harshwardhan9431

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [Nexi nets] Remove Default Case Handling
5 participants
@Harshwardhan9431 @SanchithHegde @Sangamesh26 @swangi-kumari @ArjunKarthik