-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test_utils): Add custom-headers and custom delay support to rustman #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
Area: Continuous Integration/Deployment
C-doc
Category: Documentation updates
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-test
Category: Tests
labels
Oct 18, 2023
pixincreate
force-pushed
the
custom-headers
branch
from
October 18, 2023 18:02
7df7b7c
to
d7ac816
Compare
pixincreate
force-pushed
the
custom-headers
branch
from
October 18, 2023 18:06
d7ac816
to
35232c1
Compare
pixincreate
force-pushed
the
custom-headers
branch
from
November 3, 2023 19:11
b41505a
to
6dff870
Compare
SanchithHegde
previously approved these changes
Nov 5, 2023
pixincreate
commented
Nov 6, 2023
ShankarSinghC
approved these changes
Nov 7, 2023
SanchithHegde
approved these changes
Nov 7, 2023
likhinbopanna
approved these changes
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2023
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Closes #2646
This PR as usual, narrows the main aim of rustman by making specific to Hyperswitch. With this, you should now be able to:
7
millisecondsHow custom-headers works
Custom headers inject the headers that you pass in command line into the
event.prerequest.js
file and sets a flag totrue
. After the collection is run, it checks the flag and depending on that, it willgit checkout HEAD -- <collection_name>/event.prerequest.js
to restore the file to same as before.We can also pass
-e environment.json
where you pass in custom headers but that requires some significant changes to be done to the collections to support that.Motivation and Context
This will allow us to pass different headers in run-time to test new things and also allow you to set delay of your wish. You can now set the delay to
100000000000
and wait for ages to run a single test :DHow did you test it?
Command used: (Custom headers taken from #2116)
Delay set to 0.5 seconds
In run-time, we can see the custom-headers being injected here:
Value being stored in DB:
Ran Stripe Collection:
Checklist
cargo +nightly fmt --all
cargo clippy